Users who select "Manage my team" in OldDot end up with no workspace when redirected to NewDot

[marcaaron]

cc @carlosmiceli @anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Anu
Slack conversation: https://expensify.slack.com/archives/C07HPDRELLD/p1728930765707219

Action Performed:

1. User signs up via OldDot and selects "Manage my team's expenses"
2. User is redirected to NewDot
3. App code redirects them to the step asking them how many employees they have

Expected Result:

When they select "Manage my team's expenses" on OldDot we should create a new workspace for them.

Actual Result:

We currently only create a workspace when they select "Manage my team's expenses" on NewDot.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[marcaaron]

@danieldoglas I'm working on clearing the deploy blocker here so will remove ya

[melvin-bot]

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.

[marcaaron]

Yes let's just use this issue please.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Create workspace when new user signs up, selects the "Manage my team's expenses" option and completes the "employee" step #50759

If no regressions arise, payment will be issued on 2024-10-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/Auth/pull/11953
• [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C07HPDRELLD/p1728930765707219 (not in bugs, but that's where the discussion occured.
• [@carlosmiceli] Determine if we should create a regression test for this bug.
• [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[carlosmiceli]

@marcaaron quick question, how should I approach the checklist above in this case? My understanding is that this PR didn't actually introduced a bug, but rather we need to build the proper logic separately, right?

[marcaaron]

hmm I would not prioritize the checklist personally. This is more of a "new feature" that needs to be implemented.

[carlosmiceli]

Yeah, that's what I thought, but wanted to check before ignoring the checklist 👍

[anmurali]

We will still need to explore creating the policy in the CreateAccount flow so leaving this open.

Am I correct in my understanding that we haven't started this yet?

[marcaaron]

Initially this issue was created to fix a deploy blocker (now, done). Then left open to address fixing this in the CreateAccount flow. @carlosmiceli any updates for us?

[carlosmiceli]

Not yet, couldn't make time last week, but as I mentioned to Anu I think I should be able to start this at some point halfway through this week.

[anmurali]

Could we track both the permanent fix for Manage expenses for a small team and Control expenses for a larger organization together here? In both cases we need to create a workspace in CreateAccount flow, right?

[carlosmiceli]

Yes to the second question. I'm also fine with closing this and moving both to the new issue.

[marcaaron]

Ok, sounds good. In that case I will unassign you @carlosmiceli and clean up this issue.

[marcaaron]

Actually we can close this one since there was no C+ involved.