[HOLD for payment 2024-12-05] [$250] In Search LHN, only saved search area is scrollable rather than the whole LHN being scrollable

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.64-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

Prerequisite: User have more than 4 saved searches

1. Click Search
2. Scroll the LHN

Expected Result:

The whole LHN scrolls just like it does in Settings

Actual Result:

Only saved search area is scrollable

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.777.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859709289451685912
• Upwork Job ID: 1859709289451685912
• Last Price Increase: 2024-11-21
• Automatic offers:
• allgandalf | Reviewer | 105066006

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Might be intentional we want the search types to always be visible

[shawnborton]

This is a bug, we want the whole area to be scrollable like we have on Settings.

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2024-11-21 14:42:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In search LHN, only the saved search is scrollable.

What is the root cause of that problem?

Currently, we only wrap the saved search list with a scroll view, so it's only the saved search that is scrollable.

App/src/pages/Search/SearchTypeMenu.tsx

Lines 275 to 280 in 4c44827

	<ScrollView
	onScroll={onScroll}
	ref={scrollViewRef}
	>
	{renderSavedSearchesSection(savedSearchesMenuItems())}
	</ScrollView>

What changes do you think we should make in order to solve the problem?

Wrap the whole search type menu (for non-narrow layout) in scroll view instead and remove the scroll view from the saved searches.

App/src/pages/Search/SearchTypeMenu.tsx

Lines 246 to 284 in 4c44827

	return (
	<>
	<View style={[styles.pb4, styles.mh3, styles.mt3]}>
	{typeMenuItems.map((item, index) => {
	const onPress = singleExecution(() => {
	SearchActions.clearAllFilters();
	Navigation.navigate(item.getRoute(queryJSON.policyID));
	});
	return (
	<MenuItem
	key={item.title}
	disabled={false}
	interactive
	title={item.title}
	icon={item.icon}
	iconWidth={variables.iconSizeNormal}
	iconHeight={variables.iconSizeNormal}
	wrapperStyle={styles.sectionMenuItem}
	focused={index === activeItemIndex}
	onPress={onPress}
	shouldIconUseAutoWidthStyle
	/>
	);
	})}
	</View>
	{shouldShowSavedSearchesMenuItemTitle && (
	<>
	<Text style={[styles.sectionTitle, styles.pb1, styles.mh3, styles.mt3]}>{translate('search.savedSearchesMenuItemTitle')}</Text>
	<ScrollView
	onScroll={onScroll}
	ref={scrollViewRef}
	>
	{renderSavedSearchesSection(savedSearchesMenuItems())}
	</ScrollView>
	<DeleteConfirmModal />
	</>
	)}
	</>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859709289451685912

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[allgandalf]

@bernhardoj RCA is correct and solution makes sense to me, let's go with their proposal

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @allgandalf

[allgandalf]

PR was merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make the whole search LHN menu scrollable #53106

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @allgandalf requires payment automatic offer (Reviewer)

[melvin-bot]

@allgandalf @jliexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

(hard to tell because I don't have access to original design doc, But i have asked the author about it, so maybe any of the below:)

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/48566/files#r1865459740

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Have many saved search until it's scrollable

Test:

For Large screens:

1. Open Search Page

Verify the whole search LHN is scrollable

For mobile (Small Screens):

1. Press the search type button to open the menu and verify it's scrollable

Do we agree 👍 or 👎

[jliexpensify]

Payment Summary

• C: @bernhardoj $250 (to be paid via New.Dot)
• C+: @allgandalf (to be paid via Upworks)

Upwork job

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[jliexpensify]

Paid and job closed