[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5242214&group_by=cases:section_id&group_order=asc&group_id=229064
Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Open any group chat.
3. Tap on the header and select "Members"
4. Remove members from the group.
5. Verify a system message is displayed showing this action and that the same message is seen on chat preview.
6. Tap on "Settings" on the bottom of the page.
7. Tap on "Preferences" and select "Language"
8. Change language to Spanish.
9. Return to inbox and verify that the preview of the group chat was updated to this change, and the system message on chat too.

Expected Result:

When changing language to spanish, the system message showing the action of removing group members and the preview of the chat on LHN, should be updated to this change.

Actual Result:

Message about removed members of a group in chat preview on LHN, is not updated to the language change.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6669579_1732026214491.Removed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859794304218279153
• Upwork Job ID: 1859794304218279153
• Last Price Increase: 2024-12-06
• Automatic offers:
• mkzie2 | Contributor | 105230840

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-12-04 03:51:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Message about removed members of a group in chat preview on LHN, is not updated to the language change.

What is the root cause of that problem?

We already have a case for REMOVEFROMROOM action with isInviteOrRemovedAction check here.

App/src/libs/SidebarUtils.ts

Lines 437 to 439 in 9268594

	} else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) {
	const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null;
	const targetAccountIDs = lastActionOriginalMessage?.targetAccountIDs ?? [];

But the group chat report doesn't move to this block because this condition here

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

What changes do you think we should make in order to solve the problem?

We should add a case for a group chat report here

const isGroupChat = ReportUtils.isGroupChat(report) || ReportUtils.isDeprecatedGroupDM(report);
if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage || isGroupChat) && !result.private_isArchived) {

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

What alternative solutions did you explore? (Optional)

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-19 16:29:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Preferences - When changing language, message about removed users is not changed in LHN

What is the root cause of that problem?

We are displaying a properly constructed and translated text in ReportActionItemMessage here

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 45 in 14ca237

if (ReportActionsUtils.isMemberChangeAction(action)) {

But we have forgotten to make the same translation in two places by handling isInviteOrRemovedAction case specifically

1. In LHN: Although we are handling the case for isInviteOrRemovedAction here
   

   App/src/libs/SidebarUtils.ts

   Lines 437 to 438 in 14ca237

   	} else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) {
   	const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null;

   
   It will not reach it as we haven't included isGroupChat condition here
   

   App/src/libs/SidebarUtils.ts

   Line 430 in 14ca237

   if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

2. In chat thread header title: if we create a thread with the removed system action the chat thread report header title will not have the proper translated text matching with the report action itself as we didn't handle the case in getReportName here as we did for other exceptional report action cases
   

   App/src/libs/ReportUtils.ts

   Line 4006 in 14ca237

   if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {

What changes do you think we should make in order to solve the problem?

1. We can add the isGroupChat condition in here but I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats so we should add isGroupChat condition and only for this specific case of isInviteOrRemovedAction here
   

   App/src/libs/SidebarUtils.ts

   Line 430 in 14ca237

   if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

...
result.isTaskReport ||
            ((ReportUtils.isGroupChat(report) || ReportUtils.isDeprecatedGroupDM(report)) && ReportActionsUtils.isInviteOrRemovedAction(lastAction)) ||
            isThreadMessage)
...

But if we are ok with passing through the code section we will also need to move the code that precedes it with lastActorDisplayName for group chat case from here to here
2. We should handle the isInviteOrRemovedAction in getReportName here

App/src/libs/ReportUtils.ts

Line 4006 in 14ca237

if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {

 if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isMemberChangeAction(parentReportAction)) {
            const elemets = ReportActionsUtils.getMemberChangeMessageElements(parentReportAction);
            const actionMessage = elemets.map((element) => element.content).join('');
            return formatReportLastMessageText(actionMessage);
        }

we can also optionally parse Parser.htmlToText what is returned from ReportActionsUtils.getMemberChangeMessageFragment(action).html

What alternative solutions did you explore? (Optional)

[stephanieelliott]

Tested and confirmed that the language on system messages should update

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859794304218279153

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@mkzie2

and handle this case here

Why do we need to handle this case here? If we move isGroupChat to if block, it will be false in else block. Please correct me if I miss sth

@FitseTLT

I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats

Can you show me the reason why we are doing that?

[mkzie2]

@dukenv0307 For group chat, we want to show the lastActorDisplayName with the lastMessageText then we need to update the condition handle this case as well for group chat.

Another note: Add group chat to this case will be safe because some actions are handled the same with getLastMessageTextForReport and some other actions don't exist in group chat

[FitseTLT]

@FitseTLT

I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats

Can you show me the reason why we are doing that?

@dukenv0307 I am not insisting on it, I am just mentioning it as an option as adding only isGroupChat condition might not be desirable to fix problem for one type of action as it will force it to pass through a code section that handles many other types of actions although most of the actions are more or less room and policy related except may be this one

App/src/libs/SidebarUtils.ts

Line 435 in 9268594

} else if (ReportActionsUtils.isTaskAction(lastAction)) {

if we also want the task actions handled similarly for group chats too we are good to go but in that case we will also need to move the code that precedes it with lastActorDisplayName for group chat case from here to here I have updated my proposal with this additional changed needed in case we are ok with passing through the code section 👍
However, the most important thing we should also handle is to fix getReportName as I mentioned in my proposal as without it the chat thread header name will mismatch the report action displayed 👍

[melvin-bot]

@stephanieelliott, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@stephanieelliott, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dukenv0307]

will give the update by EOD

[dukenv0307]

@mkzie2 Can we just move the isGroup chat logic to

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

For the logic, we already handle it in here

@FitseTLT

as I mentioned in my proposal as without it we would be causing a regression where the chat thread header name will mismatch the report action displayed

I think this bug is out of scope and already happens on staging, not after applying your first point.

Pls correct me if I missed sth.

[mkzie2]

@mkzie2 Can we just move the isGroup chat logic to

@dukenv0307 Checked again and you're correct, we can simply add isGroupChat to this logic.

[FitseTLT]

I think this bug is out of scope and already happens on staging, not after applying your first point.

Pls correct me if I missed sth.

Yes it might not be a regression but the root cause of the problem is when they implemented the translation of the report action they only implemented for ReportActionItem and copy to clipboard and LHN (excluding group chat) and forgot for thread header title getReportName and I can't see that out of the scope of this issue and it is closely related to the deep root cause of the issue.

[mkzie2]

I don't think it's in the scope of the issue.

1. The messages we handle in LHN and the Report screen differ. We're fixing the bug in LHN, not in the Report screen.

I can't see that out of the scope of this issue and it is closely related to the deep root cause of the issue.

2. Based on the deep root cause, the problem isn't that we don't handle the translation case for this action. We handled it here.

App/src/libs/SidebarUtils.ts

Lines 437 to 439 in 9268594

	} else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) {
	const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null;
	const targetAccountIDs = lastActionOriginalMessage?.targetAccountIDs ?? [];

The RCA is just we don't include the group chat report in this case.

cc @dukenv0307

[melvin-bot]

@stephanieelliott @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@stephanieelliott, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hey @dukenv0307 what's the next step here, are we still waiting for different proposals?

[mkzie2]

@dukenv0307 The PR is here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix remove member message in group chat is not translated in LHN #53732

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@dukenv0307 @stephanieelliott @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@marcochavezf, @stephanieelliott, @dukenv0307, @mkzie2 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@marcochavezf, @stephanieelliott, @dukenv0307, @mkzie2 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@marcochavezf, @stephanieelliott, @dukenv0307, @mkzie2 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@marcochavezf, @stephanieelliott, @dukenv0307, @mkzie2 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @marcochavezf, @stephanieelliott, @dukenv0307, @mkzie2 eroding to Weekly issue.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @mkzie2 $250 via Upwork -- PAID
• Contributor+: @dukenv0307 $250 via ND -- please request!

Upwork job is here: https://www.upwork.com/jobs/~021859794304218279153

[JmillsExpensify]

@stephanieelliott mind updating that summary with the amount please? In the meantime, $250 approved for @dukenv0307.