[$250][HOLD https://github.com/Expensify/App/pull/52164] Add workspace creation confirmation to workspace switcher.

[danielrvidal]

We're already adding the workspace confirmation to Global Create and in Settings > Workspaces. We forgot to also put the confirmation in another flow, the workspace switcher.

Can you please add the confirmation in the following screens as well.

Workspace switcher > Get started:

Workspace switcher > + New Workspace:

Video of me showing these screens:
https://github.com/user-attachments/assets/81f82325-a96b-43da-ac7a-560a277ec2eb

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853885696160356282
• Upwork Job ID: 1853885696160356282
• Last Price Increase: 2024-11-05
• Automatic offers:
• allgandalf | Reviewer | 104757767
• Krishna2323 | Contributor | 104757770

Issue Owner

Current Issue Owner: @

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021853885696160356282

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[Krishna2323]

@danielrvidal please assign me, I will work on this.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

not overdue sir melvin

[rafecolton]

Is there a WIP PR for this?

[Krishna2323]

Is there a WIP PR for this?

@rafecolton nope, we can put this on hold until this PR is being merged.

[allgandalf]

@danielrvidal lets make this one weekly, untill we merge #52164

[allgandalf]

also can you change the star to me or you @rafecolton , currently @Krishna2323 has that star so they have to comment to remove the overdue label

[rafecolton]

Done

[melvin-bot]

@rafecolton, @danielrvidal, @Krishna2323, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[danielrvidal]

We're still blocked on this one. Hopefully @allgandalf will be done with this soon: #53845

[allgandalf]

@Krishna2323 when do you expect to start working on this issue ?

[allgandalf]

@Krishna2323 are you able to work on this one, let us know if you're low on availability

[Krishna2323]

I'll work on this today, missed it because of the monthly label.

[Krishna2323]

@danielrvidal @allgandalf, I'm not sure when, but I made the necessary changes to update this in the original PR, and it's working.

Monosnap.screencast.2025-01-29.18-36-28.mp4

[allgandalf]

All good then, only payment remains @danielrvidal can you assign a BZ here please

[allgandalf]

@danielrvidal can you assign a BZ for payment please

[allgandalf]

bump on ^ @danielrvidal

[allgandalf]

can you please assign a BZ here @danielrvidal

[allgandalf]

bump for BZ assignment @danielrvidal

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[danielrvidal]

Sorry for the delay on this, I just added the BZ assignment who can help with payment.

[trjExpensify]

@danielrvidal @allgandalf, I'm not sure when, but I made the necessary changes to update this in the #52164, and it's working.

In which case, payment will be handled in #51504 which that PR is linked to, right?

[allgandalf]

In which case, payment will be handled in #51504 which that PR is linked to, right?

I guess not, The issue:

• [Due for payment 2025-01-30] [$250] Provide education/confirmation before creating workspaces in New Workspace flows #51504

Was created first, and later this issue #52075 was created and was assigned to @Krishna2323 and me, the plan was to work on #51504 first and then thiss issue, so not quite sure how payment would work in this case

I guess the contributor fixed both issues in that single PR but forgot to add this issue under the $ sign, @Krishna2323 can you comment if this assumption is correct ?

[trjExpensify]

Yeah, looks like a two line change in that PR to show the same modal on the WorkspaceSwitcherPage:

Somewhat reflective of forgetting this update was made in the original PR.

[Krishna2323]

@trjExpensify @danielrvidal I understand this was a small and straightforward change, but it would be great if you could issue payments for this. We genuinely worked hard on the original PR, and the original issue was labeled at $250, which I believe was not a fair amount considering the time and effort we put in. Unfortunately, I only realized this after implementing the changes.

We raised two significant PRs: #52164 #53845

These required a lot of effort and introduced some regression bugs, which is natural when implementing a new feature that involves multiple new pages and components.

Additionally, we also resolved this issue, which wasn’t even part of the original scope of work. We even spent time addressing an unrelated issue as part of PR #53845.

To be honest, I didn’t request a bounty increase for the original issue because I thought this small change could be considered as a bounty increase. However, I may have misjudged the situation, and if that’s the case, please feel free to close this without payments. @allgandalf please correct me if I'm wrong.

Thank you!

[trjExpensify]

We raised two significant PRs: #52164 #53845

Right, but the second PR was required because of a bunch of regressions from the first:

Additionally, we also resolved #54636, which wasn’t even part of the original scope of work.

Any context on why? All I can see is this comment about it being a follow-up in the "next PR", alluding to some changes made in the "first" PR being related? Let me know. If it was truly unrelated, I could see a $125 addition here.

We even #53845 (comment) as part of PR #53845.

Maybe I'm not following something, but we didn't fix bug in the PR did we per here?

To be honest, I didn’t request a bounty increase for the original issue because I thought this small change could be considered as a bounty increase.

The original issue didn't have the price modified for the regressions, which I think is reasonably fair given the changes, but that's a consideration for issuing more bounties on top here really.

[Krishna2323]

Any context on why? All I can see is #54636 (comment) about it being a follow-up in the "next PR", alluding to some changes made in the "first" PR being related? Let me know. If it was truly unrelated, I could see a $125 addition here.

The padding issue was found by the design team on a different screen. Later, I discovered the same bug occurring on the profile name page and fixed it there as well.

Maybe I'm not following something, but we didn't fix bug in the PR did we #53845 (comment)?

Yes, that's correct. The bug wasn't fixed. I was just pointing out that, due to an unrelated bug, we had to put in a significant amount of time and effort.

The original issue didn't have the price modified for the regressions, which I think is reasonably fair given the changes, but that's a consideration for issuing more bounties on top here really.

Thanks for explaining🙇🏻.

[trjExpensify]

The padding issue was found by the #52164 (comment) on a different screen. Later, #52164 (comment) the same bug occurring on the profile name page and fixed it there as well.

Okay cool, going to issue an additional $125 here.

Payment summary as follows:

• $125 to @allgandalf for the C+ review
• $125 to @Krishna2323 for the PR

Paid, closing!