Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Account - Validating account with wrong numbers takes you to "Connect Bank Account" #51854

Closed
1 of 8 tasks
lanitochka17 opened this issue Nov 1, 2024 · 11 comments
Closed
1 of 8 tasks
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5173639
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. profile icon > workspaces > enable workflow
  3. Tap workflow in workspace settings > connect bank account
  4. Select the Manual method to add a bank account
  5. Go through the flow until "Validate account" page
  6. Submit three random amounts

Expected Result:

"The validate code you entered is incorrect, please try again" error is shown in "Validate account" page

Actual Result:

User is navigated to "Connect bank account" page. "The validate code you entered is incorrect, please try again" error is shown in "Connect bank account" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651794_1730430092439.Screen_Recording_2024-11-01_at_5.45.41_at_night.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 1, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

The same thing happens when you click "continue" button on "complete verification" page also takes you to "Connect Bank Account" page
Clicking "continue" button should take to "Validation" page.

Screen.Recording.2024-11-01.at.5.43.35.at.night.mp4

@lakchote
Copy link
Contributor

lakchote commented Nov 1, 2024

There's a high probability it's related to #51315

@DylanDylann
Copy link
Contributor

Let's me check

@lakchote
Copy link
Contributor

lakchote commented Nov 1, 2024

I've verified @DylanDylann and it's the culprit.

@lakchote
Copy link
Contributor

lakchote commented Nov 4, 2024

Waiting for internal QA retest (see #51857 (comment)).

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@Julesssss
Copy link
Contributor

For reference, here was the retest request

@lakchote lakchote added Daily KSv2 and removed Hourly KSv2 labels Nov 4, 2024
@kavimuru
Copy link

kavimuru commented Nov 4, 2024

Not reproducible

Screen.Recording.2024-11-04.at.8.45.08.PM.mov

@lakchote
Copy link
Contributor

lakchote commented Nov 4, 2024

Great, let's close this then.

cc @Julesssss

@lakchote lakchote closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering
Projects
None yet
Development

No branches or pull requests

5 participants