[HOLD for payment 2024-11-20] [$250] Brief loading circle when accessing Company Cards page

[joekaufmanexpensify]

Problem

(Discussed here) every time you access the Company cards empty-state page on the workspace, there's a brief loading circle while we render the graphic in the middle of the page. This makes the experience feel less premium, as there isn't any significant amount of data being loaded here. It also doesn't exist for the Expensify Card empty state, which is analogous to this page.

Company cards page

2024-10-22_16-16-28.mp4

Expensify Card page

2024-10-22_16-16-53.mp4

Solution

Remove this loading indicator when accessing Company cards. If we don't need it when accessing Expensify Card empty state, it shouldn't be necessary here either, as they're essentially the same page with a different graphic.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849080892463168395
• Upwork Job ID: 1849080892463168395
• Last Price Increase: 2024-10-23
• Automatic offers:
• allgandalf | Contributor | 105194260

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[joekaufmanexpensify]

@waterim is taking this one. Once they comment here, we'll assign them!

[joekaufmanexpensify]

@shawnborton IDT there are really any design implications to this one, as it's just polish for the loading of this page. But LMK if anything comes to mind!

[waterim]

Hello Im Artem from Callstack and would like to take this one!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849080892463168395

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[shawnborton]

Sounds good, yeah this one seems pretty straightforward 👍

[Christinadobrzyn]

PR under works - #51360

[joekaufmanexpensify]

@waterim is this it? #52615

[waterim]

@joekaufmanexpensify probably, I took ticket to fix it, will update why its happening!

[melvin-bot]

@shawnborton, @rlinoz, @waterim, @Christinadobrzyn, @getusha Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@shawnborton, @rlinoz, @waterim, @Christinadobrzyn, @getusha Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[Christinadobrzyn]

Just checking in on this @waterim do you have an update? It looks like the PR is still being reviewed, is that correct? #52615

[waterim]

@Christinadobrzyn It was fixed here and merged :)

[Christinadobrzyn]

Ah thanks @waterim! So I think we can pay this out and there were no regressions, is that correct?

[Christinadobrzyn]

I'm just checking on this; I still see a loading circle - is this expected? cc @waterim @getusha This is on Mac Chrome

2024-12-03_09-59-08.mp4

[waterim]

@Christinadobrzyn yes, its expected behavior for an empty state when we dont have cardList, but once we have it we will not have a loading state

[Christinadobrzyn]

Thanks @waterim! Do we need a regression test for this? @getusha @waterim

[waterim]

Im not sure actually
Maybe @mountiny or @joekaufmanexpensify can help to answer this

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

I think we should add the regression test for this one @allgandalf. Could you please write up the regression test from the scenarios we have been discussing? I think you will be able to nail it really well

[allgandalf]

Regression Test Proposals

Regression test 1:

Precondition:

• User has a workspace with company card enabled
• There is not feed assigned to the policy
• User is logged out of the app

Test:

• Login the App
• Go to workspace with company cards enabled
• Click on Company cards

Verify that: Loading screen is shown while we fetch the company cards feed details

Regression test 2:

Precondition:

• User has a workspace with company card enabled
• There is not feed assigned to the policy
• and the user has already visited the company cards page atleast once.

Test:

• Go to workspace > Company cards

Verify that: Loading screen is shown everytime the user visits company cards page, followed by empty cards modal

Regression test 3:

Precondition:

• User has a workspace with company card enabled
• User has feed added to the policy
• User is logged out

Test:

• Login the App
• Go to workspace with company cards enabled
• Click on Company cards

Verify that: A loading screen is shown when the user visits the cards page for the first time.

Regression test 4:

Precondition:

• User has a workspace with company card enabled
• User has feed added to the policy
• and the user has already visited the company cards page atleast once.

Test:

• Go to workspace > Company cards

Verify that: There is no loading screen on the company cards page

Do we agree 👍 or 👎

[allgandalf]

These are the 4 cases i could think of for a real user, feel free to add / remove if any feels redundant

[Christinadobrzyn]

Thanks @allgandalf! Regression test here - https://github.com/Expensify/Expensify/issues/450899

So what's the payment for this:

• Contributor: @waterim is from an agency-contributor and is not due payment
• Reviewer: @getusha owed $250 via NewDot
• Reviewer: @allgandalf owed $250 via NewDot/Upwork (they will be paid in a separate GH from this one)

Is this accurate?

[rlinoz]

I think @allgandalf is being paid in the project of this other PR #52615, so only @getusha should be paid here

Correct me if I am wrong @allgandalf @mountiny

[Christinadobrzyn]

Thanks @rlinoz - @getusha can you request payment through NewDot? TY!

[mountiny]

Correct @allgandalf will be paid separately in one go probably this week

[Christinadobrzyn]

okay sounds good. @getusha can you make sure to request payment through ND.

Payment summary here - #51333 (comment)

Going to close this as complete.

[garrettmknight]

$250 approved for @getusha