[HOLD for payment 2024-11-21] [$250] Android - Compose Box - Composer not expanded when adding emojis until reaching second line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5113856&group_by=cases:section_id&group_order=asc&group_id=306201
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Expensify app
2. Open any chat
3. On compose box, add several emojis until reaching a second line
4. Verify the compose box is expanded and all the message is visible

Expected Result:

When the message with emojis reaches a second line, the compose box should expand to make all the message visible

Actual Result:

When adding several emojis and reaching a second line, the compose box is not expanded and only the second line is visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6642449_1729622425031.Expand.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851362613036850059
• Upwork Job ID: 1851362613036850059
• Last Price Increase: 2024-10-29
• Automatic offers:
• DylanDylann | Reviewer | 104755710
• QichenZhu | Contributor | 104755712

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851362613036850059

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Compose Box - Composer not expanded when adding emojis until reaching second line

What is the root cause of that problem?

We have set height: 0 here but currently the input height does not increase when adding emoji and reaching the second line. It is android's behavior

What changes do you think we should make in order to solve the problem?

1. Add new state in Composer component

const [inputContentHeight, setInputContentHeight] = useState<number | undefined>();

2. Update above state in onContentSizeChange

onContentSizeChange={(e) => {
    setInputContentHeight(e?.nativeEvent?.contentSize?.height)
    ....
}

3. Update composerStyle to bellow

const isAndroidNative = getPlatform() === CONST.PLATFORM.ANDROID
const composerStyle = useMemo(() => StyleSheet.flatten([
    style, textContainsOnlyEmojis ? styles.onlyEmojisTextLineHeight : {},
    isAndroidNative ? {height: inputContentHeight} : undefined
]), [style, textContainsOnlyEmojis, styles, inputContentHeight]);

What alternative solutions did you explore? (Optional)

[QichenZhu]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The height of live markdown input doesn't fit its content on Android if it contains emojis.

What is the root cause of that problem?

MarkdownEmojiSpan uses font size in DIP units.

AbsoluteSizeSpan(int size, boolean dip)
Set the text size to size physical pixels, or to size device-independent pixels if dip is true.

However, the text height measurement treats the font size as if it’s in pixels, so the measured height doesn't match the actual height.

What changes do you think we should make in order to solve the problem?

Use pixels in MarkdownEmojiSpan, just like in MarkdownFontSizeSpan below.

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

Reviewing on Monday

[DylanDylann]

@QichenZhu Your proposal doesn't work for me

[DylanDylann]

@shahinyan11 Could you please provide a test branch?

[QichenZhu]

@DylanDylann Sorry I didn’t clearly mention that both arguments in the constructor need to change. Here’s the code I tested with. Could you double check?

node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/spans/MarkdownEmojiSpan.java

package com.expensify.livemarkdown.spans;

import android.text.style.AbsoluteSizeSpan;

import com.facebook.react.uimanager.PixelUtil;

public class MarkdownEmojiSpan extends AbsoluteSizeSpan implements MarkdownSpan {
  public MarkdownEmojiSpan(float fontSize) {
    super((int) PixelUtil.toPixelFromDIP(fontSize), false);
  }
}

Before:

After:

[DylanDylann]

@QichenZhu Thanks for your update

@QichenZhu's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@francoisl @anmurali @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@QichenZhu Let's create a PR on App repo to upgrade https://github.com/Expensify/react-native-live-markdown version

[QichenZhu]

@DylanDylann The PR to bump the library to an earlier version has already been reviewed, so how about waiting until it's merged as jumping versions tends to cause issues?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[QichenZhu]

Still reproducible. I'll open a PR in hours.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[anmurali]

Rotating to get another BZ assigned while OOO

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump react-native-live-markdown to 0.1.183 #52286

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @QichenZhu requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Bug on the lib, also requires a reviewing from the author of lib: Fix emoji font size measurement on Android react-native-live-markdown#538 (review)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

Platform: Android

1. Open any chat.
2. In the Composer, add several emojis until it wraps to the next line.
3. Verify that the Composer expands and the full message is visible.

Do we agree 👍 or 👎

[twisterdotcom]

Payment Summary:

• @QichenZhu paid $250 here (Contributor)
• @DylanDylann paid $250 here (Reviewer)