[HOLD for payment 2024-12-05] [$250] Chat-Hidden is shown briefly on sending @new expensifail user

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9. 0.51-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: "Hidden" is shown in Hybrid app, it doesn't disappear
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open self DM
3. Enter @ and a new non existing expensifail account eg: @applausetester+1nonew@applause.expensifail.com
4. Send the message

Expected Result:

Hidden must not be shown briefly on sending @new expensifail user.

Actual Result:

Hidden is shown briefly on sending @new expensifail user.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6640933_1729511637519.Screenrecorder-2024-10-21-17-10-22-360_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849163258326584198
• Upwork Job ID: 1849163258326584198
• Last Price Increase: 2024-10-23

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is shown briefly when mentioning a user that we never chat before.

What is the root cause of that problem?

When we send a mention a receive the BE response, it will merge a new data for the mention accountID and the personal details. If the accountID is available, we look for it in the personal details list.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Lines 59 to 64 in 179d0f0

	if (!isEmpty(htmlAttribAccountID)) {
	const user = personalDetails[htmlAttribAccountID];
	accountID = parseInt(htmlAttribAccountID, 10);
	mentionDisplayText = LocalePhoneNumber.formatPhoneNumber(user?.login ?? '') || PersonalDetailsUtils.getDisplayNameOrDefault(user);
	mentionDisplayText = getShortMentionIfFound(mentionDisplayText, htmlAttributeAccountID, user?.login ?? '') ?? '';
	navigationRoute = ROUTES.PROFILE.getRoute(htmlAttribAccountID, Navigation.getReportRHPActiveRoute());

However, the personal details list from the hook here is not updated yet.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 34 in 179d0f0

const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;

So, user will be undefined and because of that, the displayName is undefined too and we fallback to Hidden briefly.

App/src/libs/PersonalDetailsUtils.ts

Line 78 in 179d0f0

return defaultValue || (shouldFallbackToHidden ? hiddenTranslation : '');

What changes do you think we should make in order to solve the problem?

We can check if both accountID and the personal details is available before using it.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Lines 59 to 60 in 179d0f0

	if (!isEmpty(htmlAttribAccountID)) {
	const user = personalDetails[htmlAttribAccountID];

if (!isEmpty(htmlAttribAccountID) && personalDetails[htmlAttribAccountID]) {
    const user = personalDetails[htmlAttribAccountID];

OR

We can use useOnyx hook instead which from my testing, updated the same time as the mention (action) accountID.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 34 in 179d0f0

const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;

OR do both

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849163258326584198

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[rushatgabhane]

@bernhardoj's proposal LGTM
we should do both, right?

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MariaHCD]

@bernhardoj's proposal looks good to me too but do is it necessary to do both?

[rushatgabhane]

if we don't do both, it might temporarily show hidden until the value is resolved. Right?

cc @bernhardoj

[bernhardoj]

Doing one of them is actually enough.

We can use useOnyx hook instead which from my testing, updated the same time as the mention (action) accountID.

I'm also suggesting doing both just in case the above isn't true anymore in the future. I think the 1st solution is the safest, but since replacing it with useOnyx is receiving the new value faster, I think there is no harm in doing both.

[MariaHCD]

Great, thanks for clarifying. Doing both sounds good to me.

[bernhardoj]

PR is ready

cc: @rushatgabhane

[melvin-bot]

This issue has not been updated in over 15 days. @johncschuster, @MariaHCD, @rushatgabhane, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hidden shows briefly when mentioning unknown user #51459

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@rushatgabhane @johncschuster @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[rushatgabhane]

1. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The issue seems pretty dated. I went back ~1.5 years. It is hard to pin point a PR.

2. If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not critical.

3. If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Yes if not already --

            1. Open any chat
            2. Mention a user that is not in your contact list (unknown user)
            3. Verify the mention doesn't change to @Hidden briefly

[bernhardoj]

Requested in ND.

[johncschuster]

Payment Summary:

Contributor: @bernhardoj due $250 via NewDot
Contributor+: @rushatgabhane due $250 via NewDot

[JmillsExpensify]

$250 approved for @bernhardoj

[garrettmknight]

$250 approved for @rushatgabhane