[HOLD for payment 2024-10-16] [HOLD for payment 2024-10-14] Composer - Suggestion list does not appear after typing @

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Type @.

Expected Result:

Suggestion list will appear (production behavior).

Actual Result:

Suggestion list does not appear.
It only appears after clearing the composer and typing @ again, or adding a space and removing the space.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6624947_1728080233929.20241005_061509.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to Live Markdown

[MuaazArshad]

Edited by proposal-police: This proposal was edited at 2024-10-05 15:29:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer - Suggestion list does not appear after typing @

What is the root cause of that problem?

We are adding this check that is preventing the initial focus

App/src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

Lines 359 to 362 in 99f280b

	if (isInitialFocusRef.current) {
	isInitialFocusRef.current = false;
	return;
	}

What changes do you think we should make in order to solve the problem?

We should remove this condition to solve the issue

Screen.Recording.2024-10-05.at.8.30.56.PM.mov

What alternative solutions did you explore? (Optional)

[github-actions]

@MuaazArshad Your proposal will be dismissed because you did not follow the proposal template.

[Shahidullah-Muffakir]

Regression from #49589

[Kalydosos]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Suggestion list does not appear after typing @

What is the root cause of that problem?

the fix deploeyed in #49589 was not restricted to Android native, thus generalize the problem to the other platforms. I'm speaking of those two sections

https://github.com/Expensify/App/blob/99f280b0edae75ff59614a1c5e98c47b39800aa5/src/pages/home/report/ReportActionCompose/SuggestionEmoji.tsx#L147C8-L150C14

and

App/src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

Lines 359 to 362 in 99f280b

	if (isInitialFocusRef.current) {
	isInitialFocusRef.current = false;
	return;
	}

What changes do you think we should make in order to solve the problem?

we should restrict avoiding the focus to Android native platform alone as it is the only platform impacted by the original issue, by modifying the 2 previous sections into

const isAndroidNative = getPlatform() === CONST.PLATFORM.ANDROID;
if (isAndroidNative && isInitialFocusRef.current) {
isInitialFocusRef.current = false;
return;
}

in both files

RESULT

the suggestions are now displayed for @

What alternative solutions did you explore? (Optional)

None

[puneetlath]

@perunt can you take a look at this?

[rlinoz]

Reverting the mentioned PR fixes it, shall we?

[puneetlath]

I think we probably should. This bug seems worse than the bug the PR was meant to fix.

[rlinoz]

Asked for CP here https://expensify.slack.com/archives/C07J32337/p1728314303541699

[rlinoz]

This is fixed by the revert so closing

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Avoid suggestion box calculation on firs input focus" #50333

If no regressions arise, payment will be issued on 2024-10-14. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath / @rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath / @rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath / @rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @rlinoz] Determine if we should create a regression test for this bug.
• [@puneetlath / @rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Avoid suggestion box calculation on firs input focus" #50333

If no regressions arise, payment will be issued on 2024-10-16. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath / @rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath / @rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath / @rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @rlinoz] Determine if we should create a regression test for this bug.
• [@puneetlath / @rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: