Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-24] [Wave Control] [QBD] [Export] Preferred exporter page #49708

Closed
lakchote opened this issue Sep 25, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lakchote
Copy link
Contributor

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.v3esmouhfimf

@lakchote
Copy link
Contributor Author

lakchote commented Oct 7, 2024

Still on hold for #49697.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Oct 7, 2024
@lakchote lakchote changed the title [HOLD #49697] [Wave Control] [QBD] [Export] Preferred exporter page [Wave Control] [QBD] [Export] Preferred exporter page Oct 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [Wave Control] [QBD] [Export] Preferred exporter page [HOLD for payment 2024-10-24] [Wave Control] [QBD] [Export] Preferred exporter page Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

@dylanexpensify dylanexpensify moved this from Release 3: Fall 2024 (Nov) to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 23, 2024
@ZhenjaHorbach
Copy link
Contributor

@lakchote
I think we need to add somebody from BZ team here !

Copy link

melvin-bot bot commented Oct 24, 2024

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Oct 24, 2024

Payment Summary

Upwork Job

BugZero Checklist (@puneetlath)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@puneetlath
Copy link
Contributor

@ZhenjaHorbach @lakchote do we need regression tests for this?

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

@puneetlath, @hoangzinh, @lakchote, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Oct 28, 2024

@ZhenjaHorbach @lakchote do we need regression tests for this?

@puneetlath

I think it will be useful !

Regression Test Proposal

  • Sign in on an account above
  • Connect your workspace to QBD
  • Set multiple admins for your workspace
  • Go to Accounting
  • Click on "Export" menu under QuickBooks Desktop connection
  • Click on Preferred exporter
  • Verify that there is a list of admins on the screen and after selecting one of them, it becomes the current exporter

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Oct 29, 2024

@ZhenjaHorbach @lakchote do we need regression tests for this?

Yes! QBD regression tests will be added centrally.

An issue has been created for it.

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@puneetlath, @hoangzinh, @lakchote, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath
Copy link
Contributor

Looks like no Upwork job was every created. @hoangzinh @ZhenjaHorbach can you ping me on this issue when you've accepted these offers?

@hoangzinh https://www.upwork.com/nx/wm/offer/104700848
@ZhenjaHorbach https://www.upwork.com/nx/wm/offer/104700852

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@ZhenjaHorbach
Copy link
Contributor

Looks like no Upwork job was every created. @hoangzinh @ZhenjaHorbach can you ping me on this issue when you've accepted these offers?

@hoangzinh https://www.upwork.com/nx/wm/offer/104700848 @ZhenjaHorbach https://www.upwork.com/nx/wm/offer/104700852

Done
Thanks !

@puneetlath
Copy link
Contributor

@ZhenjaHorbach paid. Just waiting on @hoangzinh now.

@hoangzinh
Copy link
Contributor

Accepted. Thanks @puneetlath

@puneetlath
Copy link
Contributor

All paid. Thanks y'all!

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

@puneetlath @lakchote Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

4 participants