[$250] [HOLD for payment 2024-10-17] [Wave Control] [QBD] Handle the initial connection for QBD

[lakchote]

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.uy1tfxvjfmf3

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847419775270058956
• Upwork Job ID: 1847419775270058956
• Last Price Increase: 2024-10-18
• Automatic offers:
• hoangzinh | Reviewer | 104527673
• ZhenjaHorbach | Contributor | 104527674

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBD] Handle the initial connection for QBD #50216

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847419775270058956

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@hoangzinh can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021847419775270058956

You were assigned on the date of your eligibility, since you're not setup on NewDot payments yet and I want to err on the safe side, I want to pay this via Upwork.

[hoangzinh]

Accepted the offer. Btw @mallenexpensify, @ZhenjaHorbach should be assigned to this issue as a C+ too.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

Contributor: @hoangzinh paid $250 via Upwork
Contributor+: @ZhenjaHorbach paid $250 via Upwork

@ZhenjaHorbach can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021847419775270058956

Also, plz complete the BZ checklist.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@] The PR that introduced the bug has been identified. Link to the PR:
• [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@] Determine if we should create a regression test for this bug.
• [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@] The PR that introduced the bug has been identified. Link to the PR:

New feature

• [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

New feature

• [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@] Determine if we should create a regression test for this bug.
• [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

• Sign in on an account that enabled beta quickbooksDesktopOnNewDot
• Go to any Workspace
• Enable Accounting if it hasn't enabled
• Go to Workspace's Accounting
• Verify that the QuickBooks Desktop connection is available
• Click on "Connect" button
• Verify that it shows "QuickBooks Desktop setup" page with the setup link for Web/Desktop
• Verify that it shows "Can't connect from this device" page for mWeb/Native apps

[ZhenjaHorbach]

@mallenexpensify
I accepted the offer and added BugZero Checklist
Thanks !

[mallenexpensify]

Thanks @ZhenjaHorbach , you've ben paid, payment confirmation updated above

test case created

• https://github.com/Expensify/Expensify/issues/438053