-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CVP] Bottom Up - iOS Safari - first name field is focused, but keyboard not open on the "What's your name?" page #48333
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
Triggered auto assignment to @trjExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The first name field is focused, but the keyboard is not open. What is the root cause of that problem?On iOS, focus() within setTimeout or delay may not bring the keyboard show up What changes do you think we should make in order to solve the problem?Enable What alternative solutions did you explore? (Optional)Check other places if needed |
@abdulrahuman5196 what do you think about this proposal? |
Hi will check today |
Thanks you! |
@trjExpensify Are you able to reproduce the issue? Seems to be working fine for me. Screen.Recording.2024-09-03.at.12.44.17.AM.mov |
Yup! Physical device, iPhone 15 Pro (iOS 17.6.1). RPReplay_Final1725306778.MP4 |
@trjExpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Checking again |
Thanks! |
@abdulrahuman5196 did you check? |
Not yet. I haven't been able to find how to test dev web in real iPhone's device. Checking with team on the same - https://expensify.slack.com/archives/C02NK2DQWUX/p1725898604633999 |
Cool, thanks for escalating to Slack! |
Found way to test in physical device. ios.movSometime back I remember seeing an issue where focus is not working on safari properly. Not sure if that was solved. But couldn't find that issue, will check in our slack as well if this is something we should solve here. Slack thread - https://expensify.slack.com/archives/C02NK2DQWUX/p1726080852534069 |
@trjExpensify @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
But we include autoFocus on the one page and not the other in this flow, so for the devices this does work for that makes it an inconsistent bug, right? |
#48333 (comment) - did you check this solution on a physical iPhone device using Safari, @dominictb? Can you include a vid, please. |
And FYI seems the autoFocus is removed in the |
Cool, so @dominictb. Bump on this!
|
@trjExpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@dominictb still awaiting a vid for confirmation here. |
I'm trying to build on Physical device. will update soon |
@trjExpensify My solution doesn't work on Safari Physical device. Do you think it's ios behavior to prevent showing keyboard programmatically? |
@trjExpensify, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this! |
Got it. Then yes, this sounds like the inconsistent upstream bug with mWeb safari we've (unsuccessfully) fought before. |
Yep. I think we should close this one IMO. @trjExpensify |
Yep, closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.26-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C05E8R5K55K/p1725026086476479?thread_ts=1725025982.019969&cid=C05E8R5K55K (internal)
Action Performed:
Expected Result:
When the first name field is focused, the keyboard should be open.
Actual Result:
The first name field is focused, but the keyboard is not open.
Workaround:
Yes, tap the field to bring up the keyboard.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
RPReplay_Final1725025978.MP4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @abdulrahuman5196The text was updated successfully, but these errors were encountered: