[HOLD for payment 2024-11-14] [HybridApp] Open New Expensify /travel when clicking on the HybridApp Trips tab

[AndrewGable]

Problem

We have a temporary fix in place for the new Travel feature but it has some limitations:

Solution

1. When a user clicks on Travel tab, redirect the user to New Expensify /travel via the navigateToNewDot function
   1. If the user was using Expensify Classic, we should not set their tryNewDot.classicRedirect NVP
2. When a user clicks on Book Travel in New Expensify we should open the browser as we do today, but we should take them back to Expensify Classic in the background.

The intention here is to not take the user back to New Expensify once they return back to the Expensify app.

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[AndrewGable]

Similar to this PR https://github.com/Expensify/Mobile-Expensify/pull/12700, but will require some more work!

[AndrewGable]

cc @mateuuszzzzz @staszekscp @war-in - Here is a polish issue that can be worked on once we finish all other release items

[twisterdotcom]

Still polish, prioritised correctly.

[twisterdotcom]

Same as above. Will downgrade to Monthly for now.

[twisterdotcom]

Wow, I thought I had made this Monthly.

[AndrewGable]

Bumping @mateuuszzzzz @staszekscp @war-in to see if anyone wants this one!

[mateuuszzzzz]

Hi! I'm gonna handle that one 👍

[mateuuszzzzz]

I prepared PRs they're in draft mode. I need to test Android tomorrow and then I should be able to move it to "ready for a review"

[mateuuszzzzz]

Hi, I have and update. I would like to postpone this PR until we unify the process for booting React Native on both platforms. Currently, on iOS, the app boots on startup, which leads to platform-specific implementations to ensure compatibility on iOS. This issue also affects the current PR.

I also spent some time today with @adamgrzybowski to figure out how we can integrate this feature with the current navigation. We have come up with a solution that works surprisingly well.

[AndrewGable]

Sounds good!

[mateuuszzzzz]

We managed to change how we boot RN on iOS and it works without any crashes 🎉 I presume I will continue work on this issue on Monday/Tuesday

[mateuuszzzzz]

I managed to fix all remaining issues in the blocking PR. I will continue work on Travel PR on Thursday 👍

[AndrewGable]

#47734 (comment)

[mateuuszzzzz]

Hi! I have an update

I prepared two PRs that should also fix previous issues.

OldDot, NewDot

I resolved the following issues:

• Fix android parsing issue (We don't have issue created for this one)
• Fix android blocked on travel page issue
• Fix non-HybridApp onboarding issue

I haven't addressed the iOS crash. I've just confirmed that this crash is not related to the Travel PR. It still appears in Crashlytics even after reverting the initial PRs (9.0.51.3).

What's more, it looks like after introduction of Bridgeless mode on iOS (9.0.54.1). This crash has stopped appearing in Crashlytics, so I wouldn't introduce any additional fixes. cc: @AndrewGable

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[twisterdotcom]

Looks like we're just waiting for these two PRs right? Don't wanna close this yet.

[mateuuszzzzz]

Hi, I started the implementation of betas on the OldDot side today, which is the last thing to address. I will be OOO on Thursday and Friday, and I’ll continue working on this issue on Monday.

[trjExpensify]

Confirmed with Brandon here that this is the expectation on the OldApp side:

• When not on the spotnanaTravel beta: Clicking the Travel tab on OldApp doesn’t redirect to NewDot, it opens the OldApp Trips page.
• When on the spotnanaTravel beta: Clicking the Travel tab redirects to NewDot’s book travel flow.

[mateuuszzzzz]

Hi, I had to take a day off due to a cold I’ll continue working on the PR tomorrow

[mateuuszzzzz]

I've implemented remaining betas checks

[trjExpensify]

Wahoo, and glad you're feeling better! Is it ready for a re-review?

[mateuuszzzzz]

Wahoo, and glad you're feeling better! Is it ready for a re-review?

Yes 👌

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [HybridApp] Bring back Travel to HybridApp #51327

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mateuuszzzzz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mateuuszzzzz] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.