[payment due 8-27][$250] Expense - Mark as cash button only appears in combined report after refreshing the page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4835412
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in to applausetester+pendingreceipt@applause.expensifail.com
3. Go to report https://staging.new.expensify.com/r/8085254050283210
   (the report has Mark as cash button)
4. Submit another expense
5. Click on the expense preview in the main chat to go to expense report
6. Right click on the expense submitted in Step 4 > Delete expense
7. Delete the expense in Step 4
8. Note that the combined report shows payment button instead of Mark as cash button
9. Refresh the page

Expected Result:

In Step 8, the combined report should display Mark as cash button after the other expense is deleted

Actual Result:

In Step 8, the combined report still displays payment button after the other expense is deleted
Mark as cash button only appears in the combined report after the report is refreshed (Step 9)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565724_1723129250025.20240808_224444.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d4c9cdcd61832cf
• Upwork Job ID: 1823113857893584807
• Last Price Increase: 2024-08-12
• Automatic offers:
• nkdengineer | Contributor | 103529152

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, the combined report still displays payment button after the other expense is deleted
Mark as cash button only appears in the combined report after the report is refreshed (Step 9)

What is the root cause of that problem?

The Mask as cash button is displayed if all transactions have RTER Violation.

App/src/components/MoneyReportHeader.tsx

Line 306 in e748661

{allHavePendingRTERViolation && !shouldUseNarrowLayout && (

App/src/components/MoneyReportHeader.tsx

Line 109 in e748661

const allHavePendingRTERViolation = TransactionUtils.allHavePendingRTERViolation(transactionIDs);

When we delete a transaction, allTransactions isn't updated because the dependency is only moneyRequestReport?.reportID

App/src/components/MoneyReportHeader.tsx

Line 101 in e748661

const allTransactions = useMemo(() => TransactionUtils.getAllReportTransactions(moneyRequestReport?.reportID), [moneyRequestReport?.reportID]);

Then allHavePendingRTERViolation is false and Mask as cash button doesn't appear until we refresh the page

What changes do you think we should make in order to solve the problem?

We should add transactions here as a dependency of the useMemo here as we do for ReportPreview here

App/src/components/MoneyReportHeader.tsx

Line 101 in e748661

const allTransactions = useMemo(() => TransactionUtils.getAllReportTransactions(moneyRequestReport?.reportID), [moneyRequestReport?.reportID]);

What alternative solutions did you explore? (Optional)

[trjExpensify]

wave-control project for pending card receipts. CC: @yuwenmemon @JmillsExpensify

[Christinadobrzyn]

I assume this needs to be internal but we'll add a C+ to see what they think is best.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d4c9cdcd61832cf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Ah, interesting issue. @nkdengineer proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

hi @yuwenmemon I know you just got back and are catching up but can you take a peek at this review? TY!

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

PR is in staging so getting close!

[Christinadobrzyn]

Payment didn't trigger for this one. Looks like this can be paid today.

Payouts due:

• Contributor: $250 @nkdengineer (Paid - https://www.upwork.com/nx/wm/workroom/38140679/overview)
• Contributor+: $250 @parasharrajat (paid via NewDot)

Do we need a regression test for this?

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: perf: reduce getAllReportTransactions usage in ReportPreview #46500
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/46500/files#r1733517043
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to the report has Mark as cash button
2. Submit another expense
3. Click on the expense preview in the main chat to go to expense report
4. Right click on the expense submitted in Step 2 > Delete expense
5. Delete the expense in Step 2
6. Verify that: the combined report should display Mark as cash button after the other expense is deleted

Do you agree 👍 or 👎 ?

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/424176

Paid out based on this payment summary . Closing!

[parasharrajat]

Payment requested as per #47084 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat