[HOLD for payment 2024-12-12] [$125] Web - Search - Filters - Extra margin below Save button in Category filter

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com

Action Performed:

1. Go to staging.new.expensify.com/search/filters
2. Click Category.

Expected Result:

There will be no extra margin below the Save button (production behavior).

Actual Result:

There is extra margin below the Save button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565196_1723085486947.20240808_104712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f06d1723cda4320
• Upwork Job ID: 1821488943174214137
• Last Price Increase: 2024-08-08
• Automatic offers:
• dominictb | Contributor | 103505005

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Search - Filters - Extra margin below Save button in Category filter

What is the root cause of that problem?

Extra padding bottom is applied. When we pass footer component them it is wrapped with FixedFooter which already applies the margin for the footerContent.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 138 in 53eee53

<View style={[styles.flex1, styles.pb5]}>

What changes do you think we should make in order to solve the problem?

Remove styles.pb5.

We should also remove includeSafeAreaPaddingBottom={false} if needed, the default is true so we can remove that.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 129 in 53eee53

includeSafeAreaPaddingBottom={false}

What alternative solutions did you explore? (Optional)

We can use the confirm button in SelectionList and the we can remove footer content from SearchFiltersCategoryPage.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 726 to 738 in 53eee53

	{showConfirmButton && (
	<FixedFooter style={[styles.mtAuto]}>
	<Button
	success
	large
	style={[styles.w100]}
	text={confirmButtonText || translate('common.confirm')}
	onPress={onConfirm}
	pressOnEnter
	enterKeyEventListenerPriority={1}
	/>
	</FixedFooter>
	)}

We need to pass the following props:

                        showConfirmButton
                        confirmButtonText={translate('common.save')}
                        onConfirm={handleConfirmSelection}

[cristipaval]

Definitely a NAB. Demoting.

[cristipaval]

I'm also making it a $125 issue given the low complexity of the issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f06d1723cda4320

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Upwork job price has been updated to $125

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is extra margin below the Save button.

What is the root cause of that problem?

We add pd5 to add more space in IOS device in PR, but does not consider that we do not need to add it in other platform:

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 138 in 53eee53

<View style={[styles.flex1, styles.pb5]}>

What changes do you think we should make in order to solve the problem?

We can get:

    const safePaddingBottomStyle = useSafePaddingBottomStyle();

and use it instead of styles.pb5

[melvin-bot]

This issue has not been updated in over 15 days. @cristipaval, @allroundexperts, @isabelastisser, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[isabelastisser]

I totally missed the notification, I'm sorry! @allroundexperts @BhuvaneshPatil

Is this still a bug? If yes, I will create a new issue. Thanks!

cc @cristipaval

[cristipaval]

Thanks, @isabelastisser, for the bump. This issue has been fixed. Closing.

[BhuvaneshPatil]

@isabelastisser In this comment we decided to create a new issue for another bug.

[cristipaval]

@isabelastisser In this comment we decided to create a new issue for another bug.

true, but that other bug is not reproducible anymore.

[BhuvaneshPatil]

Other bug is about not having top padding. On latest main we have no padding

[cristipaval]

Opened a PR to fix the above issue. @allroundexperts, assigned you as the C+ to test it.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix button top margin in SearchMultipleSelectionPicker #53241

If no regressions arise, payment will be issued on 2024-12-12. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

@allroundexperts / @dominictb @isabelastisser @allroundexperts / @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dominictb]

@isabelastisser Payments haven't been made here, can you help reopen the issue? TIA

[isabelastisser]

Payment summary:

@dominictb: contributor, $125. Paid in Upwork.
@allroundexperts: C+ review, $125. Payment PENDING in NewDot.

[isabelastisser]

@allroundexperts, did you already request payment for this issue in ND?

[allroundexperts]

@isabelastisser I have noted this one down. Please feel free to close.

[isabelastisser]

Thanks! All set.