[HOLD for payment 2024-08-19] [$250] iOS - Distance split - App crashes after opening split distance expense receipt

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #42302
Version Number: 9.0.18.0
Reproducible in staging?: Yes
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+0708pm1e@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Open the app and log in
2. Navigate to a group chat
3. Tap + > Split expense > Distance
4. Enter the start and finish viewpoints and complete creating a split expense
5. Open the receipt

Expected Result:

The receipt is displayed

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565083_1723073513605.IMG_8914.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bdf11a6c8415e801
• Upwork Job ID: 1821474729087191120
• Last Price Increase: 2024-08-08
• Automatic offers:
• shubham1206agra | Reviewer | 103446274
• dominictb | Contributor | 103446277

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes

What is the root cause of that problem?

Let's see the optimistic receipt data here, the source is a static image and for IOS native the type of this source is a number.

App/src/libs/actions/IOU.ts

Line 3869 in 53eee53

const receipt: Receipt | undefined = iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE ? {source: ReceiptGeneric as ReceiptSource, state: CONST.IOU.RECEIPT_STATE.OPEN} : undefined;

It leads to the optimistic filename is a number,

App/src/libs/TransactionUtils/index.ts

Line 166 in 53eee53

filename: receipt?.source ?? receipt?.name ?? filename,

Then the app crashes when we use the check Str.isPDF(receiptFilename) here because in this function we have a logic url.split('.')

What changes do you think we should make in order to solve the problem?

We should cast the receiptFilename to string when we use the Str.isPDF here

Str.isPDF(String(receiptFilename))

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 533 in 53eee53

{isLocalFile && Str.isPDF(receiptFilename) ? (

What alternative solutions did you explore? (Optional)

We can cast the filename to String here

filename: String(receipt?.source ?? receipt?.name ?? filename),

App/src/libs/TransactionUtils/index.ts

Line 166 in 53eee53

filename: receipt?.source ?? receipt?.name ?? filename,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bdf11a6c8415e801

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[shubham1206agra]

Lets go with @dominictb's alternative solution.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

@shubham1206agra You meant @dominictb right? I can't see a proposal by user @cretadn22 😄

[shubham1206agra]

@shubham1206agra You meant @dominictb right? I can't see a proposal by user @cretadn22 😄

Oh sorry. Got mixed up in 2 issues. Updated the comment now.

[dominictb]

I will raise a PR soon.

[techievivek]

The fix has been CPed to staging, going to ask QA to retest this.

[m-natarajan]

Issue fixed.

RPReplay_Final1723131816.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: enforce transaction filename to be a string #47060

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Enable distance splits #42302
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42302/files#r1715200599
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@shubham1206agra please complete BZ so we can prep for payment

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Enable distance splits #42302
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42302/files#r1715200599
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No as this was a deploy blocker and tests are already present.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

Checklist complete. All set to issue payment on Monday. We need to pay:

• @dominictb - $250 for PR via upwork.
• @shubham1206agra - $250 for C+ via Upwork

[shubham1206agra]

@joekaufmanexpensify I was not the C+ on previous issue 😄

It was @mananjadhav

[joekaufmanexpensify]

Ah, okay. I saw you listed in the assignees of the PR, but see now that was just as a commenter. Adjusted checklist!

[joekaufmanexpensify]

All set to issue payment here!

[joekaufmanexpensify]

@shubham1206agra could you please accept the offer so we can pay you?

[joekaufmanexpensify]

@dominictb $250 sent and contract ended!

[shubham1206agra]

@joekaufmanexpensify Offer accepted

[joekaufmanexpensify]

@shubham1206agra $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!