[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] [Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new account.
3. Click Chat and split expenses with friends.
4. Must repeat Step 2 and 3 until the onboarding tasks are created in Concierge chat (user ID that ends with even number) and not Expensify.

Expected Result:

Onboarding tasks will be created in Concierge chat without issue.

Actual Result:

Error shows up when onboarding tasks are created in Concierge chat.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6558581_1722458556508.onboarding.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #vip-vsb

[Beamanator]

I believe Guided Setup Stage 2 is #wave-collect

@francoisl you're leading this? https://github.com/Expensify/Expensify/issues/356685 any ideas which PR may have caused this? It looks like a backend thing but could be caused by front-end params maybe

[Beamanator]

Also maybe @marcochavezf could know since this was recently merged & seems related? https://github.com/Expensify/Web-Expensify/pull/42307 (though the issue supposedly isn't reproducible in prod)

[francoisl]

Hm weird, yes this is related to Guided Setup Stage 2, but all that code has been live for quite some time now. Were you able to repro in dev?

[francoisl]

I can reproduce in dev, seeing an 402 Invalid task type addBankAccount in the logs. I see where it comes from, trying to track where it came from 👀

[francoisl]

This is from #46359, the task enableWallet was renamed to addBankAccount but we also check the name of the tasks in the backend, so it needed to be changed there too. I don't know how the tests passed in that PR 🤔

[francoisl]

I suggest we revert that PR for now to unblock the deploy because it will require backend changes that can't be cherry-picked.

[Beamanator]

Requested CP for revert 🙏 thanks for making that, @francoisl !

[mollfpr]

Thank you, @francoisl @Beamanator for taking care of this! I did see this error while reviewing the PR, but it also working sometimes so I thought it's temporary and currently being handle internally 🙏

[Beamanator]

Revert is on staging! Time to test!

[Beamanator]

Seems to be working well on staging! Thanks for the help @francoisl !

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #46359 from nyomanjyotisa/issue-46231" #46630

If no regressions arise, payment will be issued on 2024-08-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Beamanator] Determine if we should create a regression test for this bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #46359 from nyomanjyotisa/issue-46231" #46630

If no regressions arise, payment will be issued on 2024-08-13. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Beamanator] Determine if we should create a regression test for this bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: