[Guided Setup] [$250] Replace Enable your wallet with Add personal bank account task during onboarding

[anmurali]

There are two intents Get paid back by my employer and Chat and split bills with friends where one of the onboading tasks we show is Enable your wallet. But the wallet flow is onerous and we actually have not cleaned it up to show clear and actionable error messages and this is not a priority either till more people use IOU payments.

So for now, let's replace this task with a Add personal bank account

Title: Add personal bank account
Description:

You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!
Here’s how to set up your bank account:

1. Click your profile picture.
2. Click Wallet > Bank accounts > + Add bank account.
3. Connect your bank account.

Once that’s done, you can request money from anyone and get paid back right into your personal bank account.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9b5735e8551a25a
• Upwork Job ID: 1816570512509995571
• Last Price Increase: 2024-07-25
• Automatic offers:
• nyomanjyotisa | Contributor | 103281558

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9b5735e8551a25a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[trjExpensify]

(we good here, Jon.. copy updates and shizz).

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Replace Enable your wallet with Add personal bank account task during onboarding

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

We need update the enableWallet task for both Get paid back by my employer and Chat and split bills with friends here and here with Add personal bank account:

                {
                    type: 'addBankAccount',
                    autoCompleted: false,
                    title: 'Add personal bank account',
                    description:
                        'You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!\n' +
                        '\n' +
                        'Here’s how to set up your bank account:\n' +
                        '\n' +
                        '1. Click your profile picture.\n' +
                        '2. *Click Wallet* > *Bank accounts* > *+ Add bank account*.\n' +
                        '3. Connect your bank account.\n' +
                        '\n' +
                        'Once that’s done, you can request money from anyone and get paid back right into your personal bank account.',
                },

RESULT

What alternative solutions did you explore? (Optional)

[mollfpr]

The proposal from @nyomanjyotisa looks good to me!

🎀 👀 🎀 C+ reviewed!

[anmurali]

Replace enable wallet task.

[francoisl]

Oh right, then it's easier, especially for step 3. I'd suggest making the change in multiple steps though:

1. Add a new task const that is essentially a duplicate of TASK_ENABLE_WALLET in Auth, deploy that
2. Use the new task in App, wait a bit for most clients to update
3. Remove the old task from Auth

[tgolen]

hehe, @francoisl you know a lot about this. Are you sure you aren't the volunteer I was looking for? 😉 😉

[francoisl]

If it can wait until mid next week sure, otherwise I don't think I'll have time until then.

[tgolen]

OK, I'll see if I have time to get to it before then.

…

On Wed, Aug 14, 2024 at 3:43 PM Francois Laithier ***@***.***> wrote: If it can wait until mid next week sure, otherwise I don't think I'll have time until then. — Reply to this email directly, view it on GitHub <#46231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB5SNOCT3OU4EIKUUN3ZRPFOHAVCNFSM6AAAAABLPHZJ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHE3DMOJXGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tgolen]

Daily Update

• I created an Auth PR which implements the new task as merely a copy of the old enable wallet task. The code change was straight forward, but updating the tests were not as straight forward. I hope I did them justice!

Next Steps

• @deetergp @francoisl review and merge the Auth PR
• Wait for it to deploy
• @tgolen Re-revert the frontend PR and get it merged
• @tgolen Write another Auth PR to remove the old enable wallet task

ETA

• First Auth PR merged by tomorrow, Aug 16
• Frontend PR merged and deployed by Friday, Aug 23
• Second Auth PR merged by Tuesday, Aug 27

[tgolen]

Daily Update

• The Auth PR has been merged

Next Steps

• Wait for Auth to deploy
• @nyomanjyotisa can reimplement the original PR that was reverted

ETA

• Auth deploy should happen today, Aug 20. I'll post back here when I see it's been deployed.

[kadiealexander]

@tgolen any further updates on this one? Thanks!

[tgolen]

Yeah, the auth change was deployed 3 days ago so @nyomanjyotisa can go ahead and reimplement the frontend.

[melvin-bot]

@tgolen, @mollfpr, @kadiealexander, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mollfpr]

@nyomanjyotisa Could you create the new PR? Thanks!

[kadiealexander]

@nyomanjyotisa bump!

[nyomanjyotisa]

@mollfpr PR is ready for review, sorry for the delay 🙏

[VictoriaExpensify]

@mollfpr - have you had a chance to review this yet?

[mollfpr]

@VictoriaExpensify The changes on the PR look good to me! We are waiting for the BE changes to make the task auto mark working.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good!

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Login with new account
2. Choose 'Get paid back by my employer or 'Chat and split bills with' on onboarding
3. Enter your name
4. Verify that 'Add personal bank account' task exist in Concierge chat
5. 👍 or 👎

---

@kadiealexander The PR is deployed to production last week, could you give the payment summary? Thank you!

[kadiealexander]

Payouts due:

• Contributor: $250 @nyomanjyotisa (Offer link)
• Reviewer: $250 @mollfpr via manual request

Upwork job is here.

[garrettmknight]

$250 approved for @mollfpr