[Workspace Feeds] Expensify card - Clicking back from issue cards RHP takes to wrong page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?:* Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Enable Expensify Cards on more features for that workspace
4. Go to members page on workspace
5. Select on one member
6. Click on New card
7. Click on the back icon twice

Expected Result:

The app navigates user back to the workspace members page

Actual Result:

The app navigates user to the wrong page which is Expensify card page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553624_1721993909698.bandicam_2024-07-26_12-44-15-919.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @koko57

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify card - Clicking back from issue cards RHP takes to wrong page

What is the root cause of that problem?

New card route does not accept backTo param and always returns to ROUTES.WORKSPACE_EXPENSIFY_CARD.

App/src/ROUTES.ts

Lines 884 to 887 in 2583e96

	WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW: {
	route: 'settings/workspaces/:policyID/expensify-card/issue-new',
	getRoute: (policyID: string) => `settings/workspaces/${policyID}/expensify-card/issue-new` as const,
	},

App/src/pages/workspace/card/issueNew/AssigneeStep.tsx

Line 60 in 2583e96

Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1'));

What changes do you think we should make in order to solve the problem?

• Update the route in ROUTES.ts to accept a new backTo param.

    WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW: {
        route: 'settings/workspaces/:policyID/expensify-card/issue-new',
        getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/expensify-card/issue-new`, backTo),
    },

• Pass backTo param when navigating from members page and other pages where we navigate to WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Line 242 in 69f2c05

  Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID));

Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID, Navigation.getActiveRoute()));

• Update handleBackButtonPress to check for backTo param and if present then call goBack with backTo param.
  

  App/src/pages/workspace/card/issueNew/AssigneeStep.tsx

  Lines 55 to 62 in 2583e96

  	const handleBackButtonPress = () => {
  	if (isEditing) {
  	Card.setIssueNewCardStepAndData({step: CONST.EXPENSIFY_CARD.STEP.CONFIRMATION, isEditing: false});
  	return;
  	}
  	Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1'));
  	Card.clearIssueNewCardFlow();
  	};

    const handleBackButtonPress = () => {
        if (isEditing) {
            Card.setIssueNewCardStepAndData({step: CONST.EXPENSIFY_CARD.STEP.CONFIRMATION, isEditing: false});
            return;
        }
        if (backTo) {
            Navigation.goBack(backTo as Route);
            return;
        }
        Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1'));
        Card.clearIssueNewCardFlow();
    };

What alternative solutions did you explore? (Optional)

We can simply call Navigation.goBack() instead of Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1'));.

Result

Monosnap.screencast.2024-07-26.19-59-10.mp4

[francoisl]

@kevinksullivan I believe all the Expensify Card in NewDot stuff is still in beta, is that right? Trying to see if this should really be a blocker.

[francoisl]

Discussed 1:1, this project is still in implementation phase with multiple open issues open. Going to recategorize as internal for now since I believe it's being taken care of by agency contributors and we won't need proposals, but feel free to change labels if needed.

[melvin-bot]

@Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

@francoisl, is this issue being tracked anywhere in the project? If we intend for agency contributors to pick it up, we need them to see it 😁

[Krishna2323]

@Gonals, I believe the WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW route is already completed and no one is working on a fix for this. I have a straightforward proposal if we want to fix this externally.

[francoisl]

@Gonals I would imagine this can be tracked in https://github.com/orgs/Expensify/projects/155

[melvin-bot]

@Gonals Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@Gonals Still overdue 6 days?! Let's take care of this!

[koko57]

added to the project it'll be taken care of soon

[Gonals]

Thanks!

[melvin-bot]

@Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[koko57]

will be addressed asap

[mountiny]

Not overdue, we will tackle this, the project is behind beta

[melvin-bot]

@koko57, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@koko57, @mountiny Still overdue 6 days?! Let's take care of this!

[koko57]

I'm working on it

[koko57]

PR opened #47844

[melvin-bot]

This issue has not been updated in over 15 days. @koko57, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

This is done