[HOLD for payment 2024-08-05] [$250] Sage Intacct - Workspace in "Reuse existing connection" list has different workspace avatar color

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User has a few workspaces.
• One of the workspaces is connected to Sage Intacct.
• The workspace which is connected to Sage Intacct has default workspace avatar.

1. Go to staging.new.expensify.com
2. Go to another workspace that is not connected to Sage Intacct.
3. Go to Accounting.
4. Tap Connect next to Sage Intacct.
5. Select Reuse existing connection.

Expected Result:

The workspace in "Reuse existing connection" list will have the correct workspace avatar with background color.

Actual Result:

The workspace in "Reuse existing connection" list has different workspace avatar compared to the actual workspace avatar with always blue background color surrounding the letter "A".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6548213_1721494812873.20240721_001045.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140511183d3b4ac7e
• Upwork Job ID: 1815697022094043995
• Last Price Increase: 2024-07-23
• Automatic offers:
• ishpaul777 | Reviewer | 103247884
• gijoe0295 | Contributor | 103247885

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default workspace avatar mismatch in existing connections page.

What is the root cause of that problem?

We're missing avatarID causing the avatar background to be computed incorrectly:

App/src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

Lines 29 to 33 in c3b1ff2

	title: policy.name,
	key: policy.id,
	icon: policy.avatarURL ? policy.avatarURL : ReportUtils.getDefaultWorkspaceAvatar(policy.name),
	iconType: policy.avatarURL ? CONST.ICON_TYPE_AVATAR : CONST.ICON_TYPE_WORKSPACE,
	description: date ? translate('workspace.common.lastSyncDate', CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY.intacct, date) : translate('workspace.accounting.intacct'),

App/src/components/Avatar.tsx

Lines 97 to 98 in 6562f74

	if (isWorkspace) {
	iconColors = StyleUtils.getDefaultWorkspaceAvatarColor(avatarID?.toString() ?? '');

What changes do you think we should make in order to solve the problem?

Add avatarID as policy.id for the above menuItems.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140511183d3b4ac7e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[ishpaul777]

reviewing 👀

[ishpaul777]

@m-natarajan @bfitzexpensify Do we have any testing credentials for sage intacct integration or steps to to have a test acccount ?

[gijoe0295]

For me, I hard coded because as elaborated in my proposal, root cause is not related to data:

1. Navigate to ExistingConnectionsPage on press Connect:

App/src/components/ConnectToSageIntacctButton/index.tsx

Line 64 in 03863a6

onPress={() => {

Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_EXISTING_CONNECTIONS.getRoute(policyID));

2. Return any policy data in this function:

App/src/libs/actions/Policy/Policy.ts

Line 3148 in e0581a8

function getAdminPoliciesConnectedToSageIntacct(): Policy[] {

[ishpaul777]

it makes sense 👍 Thanks @gijoe0295.

---

Proposal from @gijoe0295 LGTM!

It appears we have the same issue in netsuite existing-connections page lets fix it in the PR also

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Avatar mismatch in existing connection page #46170

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment automatic offer (Reviewer)
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[gijoe0295]

@bfitzexpensify @ishpaul777 It's payment due.

[bfitzexpensify]

Hey @gijoe0295 - are you seeing anything strange with the contract on your end? When I attempt to close and pay it out, I am seeing this error:

[gijoe0295]

@bfitzexpensify There was no problem on my side. I received the payment.

[bfitzexpensify]

Great, thanks for confirming. @ishpaul777 if you can get the BZ checklist complete I'll finalise the C+ payout too

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: Connect to sage intacct #43661
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43661/files#r1712681378
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@ishpaul777] Determine if we should create a regression test for this bug. No this was minor issue because of a missing prop., no need for regression test.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[bfitzexpensify]

Thanks @ishpaul777 - offer sent.

[ishpaul777]

Accepted offer! Thank you

[bfitzexpensify]

Great - all paid out. Thanks everyone!