[HOLD for payment 2024-08-07] [Workspace Feeds] Design adjustments part 1

[mountiny]

Coming from some initial testing here the design team suggested some adjustments. @shawnborton @allgandalf @DylanDylann @VickyStash @narefyev91

I believe @koko57 is fixing this one in #45690

The empty state doesn't have the correct amount of padding on desktop... it should use 32px on desktop and 20px on mobile. Compare with the workspace empty state for example:

---

When going through the issue card flow, the selected limit type in Step 3 does not have the correct background color applied to it. Compare it to other list options for example:

---

The text below the headline of step 6 is too small (it's 13px, but it should be 15px) and is too far away from the headline (should be just 12px margin between headline and text from what I see elsewhere). Compare this to other stepped flows for example:

---

Update the spacing at the empty state #45690 (comment)

Let's add 32px of space below the two buttons and above the empty state rows.

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

we will handle this internally

[koko57]

@mountiny please assign me - I will either create a separate PR for that or will do it together with the flow integration with the BE. The first problem with the padding is solved in #45690

[trjExpensify]

Assigned!

[koko57]

I fixed the issues and I could open the PR now, but there is an improvement with option focus change implemented by @VickyStash here: #45601 so it's better to wait on this one to be merged so these changes would also be incorporated here

[mountiny]

going to be handled soon

[mountiny]

There is one more little cleanup to add from @shawnborton #45690 (comment) adding it to the gh body too

[koko57]

not sure what happened here - while working on empty state modal PR this was looking ok on android - but now the SVG is cut off

I'm trying to fix it now, that why I'm still not opening the draft for review

[mountiny]

Thanks for an update

[koko57]

ok, ready for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Design improvements #45996

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@koko57] Determine if we should create a regression test for this bug.
• [@koko57] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[strepanier03]

@mountiny - Do we need the checklist here?

If not, feel free to close this, there is no payment due according to Melvin-bot.

[mountiny]

Yah I dont thinkwe need that here