Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-29] [$250] Deeplink - Duplicate concierge chat is displayed on LHN when deeplinking to concierge #44465

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 26, 2024 · 101 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44063

Action Performed:

  1. Sign out from ND
  2. Paste this link to the browser tab https://staging.new.expensify.com/concierge
  3. Press Enter key
  4. Enter a new user email address in the email field
  5. Click Continue button
  6. Click the Join button
  7. While staying in the onboarding process, observe the LHN

Expected Result:

Only one concierge chat is displayed on the LHN

Actual Result:

Duplicate concierge chat is briefly displayed on the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6524808_1719378689822.2024-06-26_08_06_58.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01761bb8fe9958d8df
  • Upwork Job ID: 1808128563862616294
  • Last Price Increase: 2024-10-16
Issue OwnerCurrent Issue Owner: @getusha
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@melvin-bot melvin-bot bot added the Overdue label Jun 28, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

@sonialiap sonialiap added the External Added to denote the issue can be worked on by a contributor label Jul 2, 2024
@melvin-bot melvin-bot bot changed the title Deeplink - Duplicate concierge chat is displayed on LHN when deeplinking to concierge [$250] Deeplink - Duplicate concierge chat is displayed on LHN when deeplinking to concierge Jul 2, 2024
Copy link

melvin-bot bot commented Jul 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01761bb8fe9958d8df

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 2, 2024
Copy link

melvin-bot bot commented Jul 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@jnowakow
Copy link
Contributor

jnowakow commented Jul 3, 2024

Hello, I'm from SoftwareMansion, an expert agency, and I'm going to work on this one

@jnowakow
Copy link
Contributor

jnowakow commented Jul 3, 2024

It's strange, I'm able to reproduce this issue on staging but when I try to do so on local build it works correctly:

repro2-720.mov

@getusha
Copy link
Contributor

getusha commented Jul 4, 2024

Same, not able to reproduce this on local build.

Screenshot 2024-07-04 at 12 58 25 in the afternoon

Copy link

melvin-bot bot commented Jul 9, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

@sonialiap, @getusha Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jul 10, 2024

@sonialiap @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jul 11, 2024

@sonialiap, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@sonialiap
Copy link
Contributor

@jnowakow @getusha I'm not sure how local build is created (not an engineer 😅), is the local build based on staging or is it possible for staging to be different from a local build? Maybe the builds have to be renewed?

Copy link

melvin-bot bot commented Jul 15, 2024

@sonialiap, @getusha 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Jul 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jul 17, 2024

@sonialiap, @getusha 12 days overdue now... This issue's end is nigh!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jul 22, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 22, 2024
@melvin-bot melvin-bot bot changed the title [$250] Deeplink - Duplicate concierge chat is displayed on LHN when deeplinking to concierge [HOLD for payment 2024-11-29] [$250] Deeplink - Duplicate concierge chat is displayed on LHN when deeplinking to concierge Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment through NewDot Manual Requests
  • @ugogiordano requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Nov 22, 2024

@getusha @sonialiap @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

Payment Summary

Upwork Job

BugZero Checklist (@sonialiap)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1808128563862616294/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@sonialiap
Copy link
Contributor

sonialiap commented Dec 2, 2024

Payment summary:

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@ugogiordano
Copy link
Contributor

@sonialiap, can I get the offer on the first "Upwork Profile for payment" you can see on my bio? I have attached the VAT ID to it.

@sonialiap
Copy link
Contributor

@ugogiordano the offer should be sent to Rosaria V., is that correct?

@ugogiordano
Copy link
Contributor

ugogiordano commented Dec 3, 2024

@ugogiordano the offer should be sent to Rosaria V., is that correct?

Yes, correct, thank you so much!

@sonialiap
Copy link
Contributor

sonialiap commented Dec 3, 2024

@ugogiordano offer paid!

https://www.upwork.com/nx/wm/offer/105173644

Copy link

melvin-bot bot commented Dec 9, 2024

@sonialiap, @getusha, @aldo-expensify, @ugogiordano Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@sonialiap
Copy link
Contributor

@getusha bumping for the checklist :)

Copy link

melvin-bot bot commented Dec 11, 2024

@sonialiap, @getusha, @aldo-expensify, @ugogiordano Still overdue 6 days?! Let's take care of this!

@getusha
Copy link
Contributor

getusha commented Dec 12, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

We already have a regression test created for this issue #17884

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2024
@sonialiap
Copy link
Contributor

Thanks!

@garrettmknight
Copy link
Contributor

$250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests