[HOLD for payment 2024-06-03] [$250] Task - Deleted #admins room displayed in share somewhere when creating task

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4516164
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app and log in
2. Create a workspace
3. Add some message to #admins room
4. Tap FAB > Assign task
5. Create a task and share in the #admins room
6. Delete the workspace
7. Tap FAB > Assign task
8. Open Share somewhere on the task confirmation screen

Expected Result:

#Admins room from the deleted workspace is not displayed

Actual Result:

#Admins room from the deleted workspace is displayed and can be selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462182_1714084057568.video_2024-04-25_15-14-58.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190dd051f8a814833
• Upwork Job ID: 1784888107450617856
• Last Price Increase: 2024-04-29
• Automatic offers:
• c3024 | Contributor | 0
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

#Admins room from the deleted workspace is displayed and can be selected

What is the root cause of that problem?

We're using useOptionsList hook to get optionList

When reports change we update the optionList in

App/src/components/OptionListContextProvider.tsx

Lines 50 to 53 in e280478

	/**
	* This effect is used to update the options list when a report is updated.
	*/
	useEffect(() => {

But we just get the last updated report

App/src/components/OptionListContextProvider.tsx

Line 59 in e280478

const lastUpdatedReport = ReportUtils.getLastUpdatedReport();

In this case it's not correct since when users delete WS, 3 reports are updated (chat, admin, announce) -> just only chat is updated

What changes do you think we should make in order to solve the problem?

We should not update the last updated report because of the above reason, instead of that we can do the same with personalDetails

App/src/components/OptionListContextProvider.tsx

Line 114 in e280478

const newPersonalDetailsOptions = OptionsListUtils.createOptionList(personalDetails).personalDetails;

        const newReports = OptionsListUtils.createOptionList({}, reports).reports;

        setOptions((prevOptions) => {
            const newOptions = {...prevOptions};
            newOptions.reports = newReports
            return newOptions;
        });

To improve the performance, we can compare the newReports with the current reports before decide to update them

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190dd051f8a814833

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Will reivew it tomorrow morning.

[c3024]

@parasharrajat I can take this if you are OOO and have limited capacity. (context)

[garrettmknight]

@c3024 you're up!

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[c3024]

@tienifr 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: missing personal details while creating options list #42238

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Contributor)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Payment Summary:

• Contributor: @tienifr $250 paid via upwork
• Reviewer: @c3024 $250 paid via upwork

[garrettmknight]

@c3024 can you complete the checklist when you get a minute?

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@c3024] The PR that introduced the bug has been identified. Link to the PR: #38207
[x] [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: tienifr@623810f#r142714903
[x] [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this miss cannot be included in a checklist.
[x] [@c3024] Determine if we should create a regression test for this bug. Yes
[x] [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Tap FAB > Assign task
2. Create a task and share in any workspace's #admins room
3. Delete that workspace
4. Tap FAB > Assign task
5. Open Share somewhere
6. Verify the #admins room of the above deleted workspace does not show up in the options

👍 or 👎

[garrettmknight]

Done!