Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Track expense - App shows skeleton when saving track expense edit for the second time onward #40862

Closed
2 of 6 tasks
izarutskaya opened this issue Apr 24, 2024 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Track expense.
  3. Track a manual expense to self.
  4. Go to transaction thread.
  5. Click Amount.
  6. Edit the amount and save it.
  7. Click Amount.
  8. Edit the amount and save it.

Expected Result:

App will not show skeleton when saving track expense edit for the second time.

Actual Result:

App shows skeleton when saving track expense edit for the second time onward.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6459942_1713948781081.track_expense_edit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01072100fbd6058c80
  • Upwork Job ID: 1783235013921456128
  • Last Price Increase: 2024-05-01
Issue OwnerCurrent Issue Owner: @thienlnam
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@izarutskaya
Copy link
Author

Production

bandicam.2024-04-24.13-16-17-416.mp4

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 24, 2024
@mountiny
Copy link
Contributor

Removing a blocker label as it does the work and user is not blocker and this is mainly ui issue cc @thienlnam

@mountiny
Copy link
Contributor

@allroundexperts @shubham1206agra @s77rt this might be related to #39956 your PR

@allroundexperts
Copy link
Contributor

This was a known issue that we discussed during PR review as well. @shubham1206agra mentioned that it was happening on prod as well.

@thienlnam thienlnam assigned thienlnam and unassigned cristipaval Apr 24, 2024
@thienlnam
Copy link
Contributor

Yeah, we're not entirely sure why this is happening - going to open up externally so someone can investigate

@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Apr 24, 2024
@melvin-bot melvin-bot bot changed the title Track expense - App shows skeleton when saving track expense edit for the second time onward [$250] Track expense - App shows skeleton when saving track expense edit for the second time onward Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01072100fbd6058c80

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@thienlnam thienlnam added Internal Requires API changes or must be handled by Expensify staff Overdue and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@thienlnam thienlnam removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

@mananjadhav, @thienlnam, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?

@bfitzexpensify
Copy link
Contributor

@thienlnam is this one you're planning to handle yourself?

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
Copy link

melvin-bot bot commented May 8, 2024

@mananjadhav @thienlnam @bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@thienlnam
Copy link
Contributor

thienlnam commented May 8, 2024

Yeah though I'm currently working on some other track issues so going to demote this once since it's not blocking functionality or anything

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels May 8, 2024
@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@thienlnam
Copy link
Contributor

Same ^

@melvin-bot melvin-bot bot removed the Overdue label May 18, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@mananjadhav
Copy link
Collaborator

@thienlnam Are we looking to pick this soon?

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@thienlnam
Copy link
Contributor

Just came back from OOO, this is lower on the list of priorities so probably not this week

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2024
@thienlnam
Copy link
Contributor

Same - not a priority at this time

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@thienlnam
Copy link
Contributor

vip-vsb is paused, going to close this since we are reprioritizing

@thienlnam thienlnam closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@nkdengineer
Copy link
Contributor

@thienlnam We have a good solution to fix in front-end, and we can do it now if you think it's acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants