[HOLD for payment 2024-04-25] [$500] iOS - Wallet - Bank button is not responsive

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4488516
Email or phone of affected tester (no customers): applausetester+vd_ios041024.3@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: user must have created a Workspace and have added a bank account to the WS, so the bank account can be displayed on the Wallet page.

1. Go to Settings > Wallet.
2. Tap on the added bank account or on the 3 dots menu to the right of it.
3. Verify it is not responsive.

Expected Result:

The bank button and the 3 dots menu should be responsive.

Actual Result:

The bank button and the 3 dots menu are not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6445237_1712792776326.Fglf3793_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01955b986561b0d5cb
• Upwork Job ID: 1778388746136018944
• Last Price Increase: 2024-04-11

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

RPReplay_Final1712806014.MP4

[Julesssss]

Hey @izarutskaya, is the video marked production correct? It looks like a different issue that was opened

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01955b986561b0d5cb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ghost]

Production

RPReplay_Final1712806014.MP4

This video is not related to this issue @izarutskaya

[melvin-bot]

Upwork job price has been updated to $500

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Wallet - Bank button is not responsive

What is the root cause of that problem?

I think the problem is with native view for wallet page i.e. here

What changes do you think we should make in order to solve the problem?

I think we need to redesign wallet page for native devices.

What alternative solutions did you explore? (Optional)

N/A

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Bank button is not responsive

What is the root cause of that problem?

The main problem with this issue is that we use FlashList to show elements which for some reason doesn't work
Even if we make this list the only one on the screen
Or we will use a primitive button as a list element

So the problem is most likely on the native side of FlashList

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Lines 339 to 348 in 4e8786b

	<FlashList
	estimatedItemSize={variables.optionRowHeight}
	data={filteredPaymentMethods}
	renderItem={renderItem}
	keyExtractor={keyExtractor}
	ListEmptyComponent={shouldShowEmptyListMessage ? renderListEmptyComponent : null}
	ListHeaderComponent={listHeaderComponent}
	onContentSizeChange={onListContentSizeChange}
	scrollEnabled={shouldEnableScroll}
	/>

What changes do you think we should make in order to solve the problem?

After testing I came to the conclusion
A possible fix is to use a FlatList instead of a FlashList
Plus I don't see a lot of reason why we decided to use FlashList for PaymentMethods since this doesn’t make much sense, unlike the same list of emojis

What alternative solutions did you explore? (Optional)

NA

[ikevin127]

@godofoutcasts94 Thanks for the proposal! Unfortunately your RCA and solution are not correct.

[melvin-bot]

@nkuoch, @MitchExpensify, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

If all the issues are related to the patch and Flashlist. Let's hold these issues to be assigned to anyone until we have a fix for that.

Which issues were you referring to holding on specifically @parasharrajat ?

[parasharrajat]

Here is a list.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kosmydel]

Hey, I'm from Software Mansion.

I was unable to reproduce this issue on v.1.4.62-10 Develop version. I followed the steps from the original post and this comment.

Can someone confirm, that the issue is still reproducible?

EDIT: Okay, it was working for 2 bank accounts. I can reproduce this issue only when we have exactly one bank account added.

[ikevin127]

Could you check if #40191 solves the issue?

@WoLewicki I confirm that with a clean build of #40191, the issue is fixed 🎉

[roryabraham]

I'm not able to reproduce this on main - requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1713291635862759

edit: whoops, I was testing Android instead of iOS

[kbecciv]

@roryabraham Issue is still reproducible on IOS app with build 1.4.62.11

RPReplay_Final1713294023.MP4

[roryabraham]

ok, I was able to reproduce this on main

[roryabraham]

This will be fixed by #40191 in 1.4.62-13, deploying here

[roryabraham]

confirmed this is fixed on staging, no payments due so I'm closing it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] feat: change new arch flash list to interop #40191

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: