[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824

lanitochka17 · 2024-03-22T18:17:03Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Actual Result:

Go to staging.new.expensify.com
Go to Profile > Workspaces
Create a new workspace
Click Share icon
Click Copy
Paste the link in chat and send it
Click on the link

Expected Result:

The left side bar will be menu

Actual Result:

The left side bar remains as chat when clicking on WS invitation link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6423434_1711128140057.20240323_011952.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01959b571907654054
Upwork Job ID: 1771275226175332352
Last Price Increase: 2024-04-09
Automatic offers:

Ollyws | Reviewer | 0
tienifr | Contributor | 0

github-actions · 2024-03-22T18:17:19Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2024-03-22T18:17:30Z

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

lanitochka17 · 2024-03-22T18:17:44Z

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-03-22T18:18:02Z

We think that this bug might be related to #wave-collect - Release 1

iwiznia · 2024-03-22T18:20:37Z

The left side bar will be menu

I have no idea what this means, can someone clarify?

ahmedGaber93 · 2024-03-22T18:53:27Z

@iwiznia
it means it should be profile menu not chat list menu

Expected Result:

Actual Result:

ghost · 2024-03-22T19:54:31Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - The left side bar remains as chat when clicking on WS invitation link

What is the root cause of that problem?

Here :

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Line 48 in 107b378

Navigation.goBack(undefined, false, true);

we are defining routes as Navigation.goBack(undefined, false, true); which is taking us back but with inconsistency as
Navigation.goBack method is used to return to the previous screen, passing undefined to not pop any screens from the stack, false to not animate the transition, and true to dismiss the keyboard if open but while doing all that it causes inconsistency and we have already defined navigateAfterJoinRequest which is taking care of it.

What changes do you think we should make in order to solve the problem?

So, we need to replace this -

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Line 48 in 107b378

Navigation.goBack(undefined, false, true);

with this - navigateAfterJoinRequest();

What alternative solutions did you explore? (Optional)

I think alternatively we can navigate the user to Workspace Initial Page :

Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? ''));

Result

Screen.Recording.2024-03-23.at.1.30.08.AM.mp4

ghost · 2024-03-22T20:02:57Z

Updated Proposal with result

melvin-bot · 2024-03-22T20:38:18Z

Job added to Upwork: https://www.upwork.com/jobs/~01959b571907654054

melvin-bot · 2024-03-22T20:38:24Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

allgandalf · 2024-03-22T20:44:39Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We are simply navigating back to the previous route if the user is the policy member of the workspace which causes this error:

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Line 48 in 107b378

Navigation.goBack(undefined, false, true);

What changes do you think we should make in order to solve the problem?

We should navigate to the Settings page of that Workspace if the currrent user is already the member of workspace:

Navigation.Navigate(ROUTES.WORKSPACE_INITIAL.getRoute( policyID ?? ''));

What alternative solutions did you explore? (Optional)

Not sure but we can navigate to all Workspace page:

App/src/ROUTES.ts

Line 80 in 416c759

SETTINGS_WORKSPACES: 'settings/workspaces',

bernhardoj · 2024-03-23T05:48:18Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we open a workspace invite link while already a member, the workspace list is shown with an LHN.

What is the root cause of that problem?

Currently, when we are already a member of the workspace, we will just close the page.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 47 to 50 in 191d932

    
           if (isPolicyMember) { 
        
               Navigation.goBack(undefined, false, true); 
        
               return; 
        
           }

But the logic above is triggered twice, so we got navigated twice. If we go from the chat/report screen to the workspace list page, then go to the report screen again [chat, WS, chat], then when the twice go back navigation happens, we arrive at the workspace list page instead of the LHN. The first go back pops the workspace join page, and the second go back pops the chat page.

The reason it is triggered twice is because of the onyx policies object changes. The second policies object somehow contains either policy_0, policy_undefined, or both. But if we deep link to the page, the onyx still re-renders the components with the same policies object even though the values are the same. After doing some investigation, onyx first provides the data when the component mounts, then it connects to the key and provides the data again when successfully connected, so we got the data twice even though they are the same.

For the policy_0 and policy_undefined, it happens because there are some component that tries to connect to those keys so it's added to the collection.

What changes do you think we should make in order to solve the problem?

I'm not focusing on the onyx issue, but rather on the useEffect itself.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 42 to 59 in 191d932

    
           useEffect(() => { 
        
               if (!policy || !policies || isUnmounted.current || isJoinLinkUsed) { 
        
                   return; 
        
               } 
        
               const isPolicyMember = PolicyUtils.isPolicyMember(policyID, policies as Record<string, Policy>); 
        
               if (isPolicyMember) { 
        
                   Navigation.goBack(undefined, false, true); 
        
                   return; 
        
               } 
        
               PolicyAction.inviteMemberToWorkspace(policyID, inviterEmail); 
        
               isJoinLinkUsed = true; 
        
               Navigation.isNavigationReady().then(() => { 
        
                   if (isUnmounted.current) { 
        
                       return; 
        
                   } 
        
                   navigateAfterJoinRequest(); 
        
               }); 
        
           }, [policy, policyID, policies, inviterEmail]);

I propose to remove the effect dependencies as I believe we only want to run the logic once and not every time one of the deps is updated.

btw, we should add Navigation.isNavigationReady() before calling the goBack, otherwise it will fail when we deep link to it

What alternative solutions did you explore? (Optional)

If we want to keep the deps, then we can memoize this
const isPolicyMember = PolicyUtils.isPolicyMember(policyID, policies as Record<string, Policy>);

const isPolicyMember = useMemo(() => PolicyUtils.isPolicyMember(policyID, policies as Record<string, Policy>), [policyID, policies]);

Then we can take out the policies object collection from the effect and replace it with isPolicyMember.

tienifr · 2024-03-23T06:15:13Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The left side bar remains as chat when clicking on WS invitation link

What is the root cause of that problem?

In here, when the user is already a policy member, we're triggering Navigation.goBack(undefined, false, true); which will navigate the user back, which is not correct since the user wouldn't know what's going on, they're right back at the report screen, which seems more like the navigation doesn't work than they've been navigated to the right page by the link.

IMO we should:

Navigate to the workspace initial page if the user is already a policy member
Optionally show a message like "You're already a member of this workspace" to let the user know what's going on.

What changes do you think we should make in order to solve the problem?

We have to goBack, then navigate the user to the correct workspace page. We should replace this by

Navigation.isNavigationReady().then(() => {
    Navigation.goBack(undefined, false, true);
    Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? '')); 
})

We have to:

goBack first, then navigate (unlike some proposals which suggest to replace goBack with navigate). Because we want to pop the current WorkspaceJoinUserPage first then navigate, otherwise if after navigation, the user goes back, they will incorrectly go back to the WorkspaceJoinUserPage. This is the approach used everywhere in the app like here
We have to do those navigation inside Navigation.isNavigationReady(), if not the navigation will not work and will cause unexpected navigation

If we want to go with this, we should:

Add a route params when navigating back to WorkspaceInitialPage, like fromInviteLink=true (or we can use a simple JS variable, should be fine too)
In WorkspaceInitialPage if we see that fromInviteLink is true, show the "You're already a member of this workspace" (exact design can be provided by the design team)

What alternative solutions did you explore? (Optional)

For 1 instead of Navigation.goBack(undefined, false, true);, we could use Navigation.goBack()

Instead of WorkspaceInitialPage, another destination like ROUTES.SETTINGS_WORKSPACES could be considered, but definitely we should not just goBack, as I explained in the RCA it's confusing UX.

Ollyws · 2024-03-24T20:45:33Z

@tienifr's proposal LGTM.
🎀👀🎀 C+ reviewed

melvin-bot · 2024-03-24T20:45:42Z

Current assignee @iwiznia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

bernhardoj · 2024-03-25T04:14:42Z

@Ollyws hi, have you checked my proposal? I think the real issue here is the double navigation. Navigating to another page doesn't fix the root cause.

Without fixing the double navigation, you will see the user gets navigated to the WS page (if we navigate to it) twice.

Screen.Recording.2024-03-25.at.12.04.18.mov

Ollyws · 2024-03-25T10:28:56Z

@bernhardoj I did and I'm not sure that it's the root cause here.
I can't reproduce that issue with @tienifr's solution:

Screen.Recording.2024-03-25.at.11.26.48.mov

bernhardoj · 2024-03-25T10:35:55Z

Oh my bad, I didn't put it inside the isNavigationReady promise. Somehow the promise resolve is only called once.

I'm not sure that it's the root cause here.

You can test (without changing any code) by clicking the link and see the chat page will close.

melvin-bot · 2024-03-25T16:36:37Z

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-04-02T10:59:34Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-04-02T10:59:36Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix left side bar remains as chat when clicking on invitation #38984

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

@Ollyws requires payment automatic offer (Reviewer)
@tienifr requires payment automatic offer (Contributor)

Ollyws · 2024-04-09T10:51:30Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR:

#37525

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/37525/files#r1557429884

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces
3. Create a new workspace
4. Click Share icon
5. Click Copy
6. Paste the link in chat and send it
7. Click on the link
8. Verify the menu appears in the left side bar

Do we agree 👍 or 👎

Ollyws · 2024-04-09T10:52:33Z

@iwiznia Could we get a BZ member assigned for payment? Thanks.

melvin-bot · 2024-04-09T16:42:44Z

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2024-04-09T16:42:50Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Ollyws · 2024-04-09T17:19:19Z

Hmm why did melvin downgrade the price to $250...I think this one should be $500 as it was created before the 5th April.

joekaufmanexpensify · 2024-04-09T20:52:46Z

Yep, you're right.

melvin-bot · 2024-04-09T20:52:58Z

Upwork job price has been updated to $500

joekaufmanexpensify · 2024-04-09T21:04:28Z

Regression test is here: https://github.com/Expensify/Expensify/issues/386545

joekaufmanexpensify · 2024-04-09T21:05:16Z

All set to issue payment. We need to pay:

@tienifr $500 for PR via upwork.
@Ollyws $500 for C+ via upwork.

joekaufmanexpensify · 2024-04-09T21:06:48Z

@Ollyws $500 sent and contract ended!

joekaufmanexpensify · 2024-04-09T21:06:57Z

@tienifr $500 sent and contract ended!

joekaufmanexpensify · 2024-04-09T21:07:08Z

Upwork job closed.

joekaufmanexpensify · 2024-04-09T21:07:14Z

All set. Thanks everyone!

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 22, 2024

github-actions bot added Engineering Hourly KSv2 labels Mar 22, 2024

melvin-bot bot assigned iwiznia Mar 22, 2024

github-actions bot mentioned this issue Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

iwiznia added the External Added to denote the issue can be worked on by a contributor label Mar 22, 2024

melvin-bot bot changed the title ~~Workspace - The left side bar remains as chat when clicking on WS invitation link~~ [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link Mar 22, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 22, 2024

melvin-bot bot assigned Ollyws Mar 22, 2024

iwiznia assigned tienifr Mar 25, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 25, 2024

melvin-bot bot changed the title ~~[$500] Workspace - The left side bar remains as chat when clicking on WS invitation link~~ [HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link Apr 2, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 8, 2024

Ollyws mentioned this issue Apr 9, 2024

Invite user to workspace via invite link #37525

Merged

50 tasks

melvin-bot bot removed the Overdue label Apr 9, 2024

iwiznia added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. and removed External Added to denote the issue can be worked on by a contributor labels Apr 9, 2024

melvin-bot bot changed the title ~~[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link~~ [HOLD for payment 2024-04-09] [$250] Workspace - The left side bar remains as chat when clicking on WS invitation link Apr 9, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 9, 2024

melvin-bot bot assigned joekaufmanexpensify Apr 9, 2024

joekaufmanexpensify changed the title ~~[HOLD for payment 2024-04-09] [$250] Workspace - The left side bar remains as chat when clicking on WS invitation link~~ [HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link Apr 9, 2024

joekaufmanexpensify closed this as completed Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824

[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824

lanitochka17 commented Mar 22, 2024 •

edited by melvin-bot bot

Loading

github-actions bot commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

iwiznia commented Mar 22, 2024

ahmedGaber93 commented Mar 22, 2024

ghost commented Mar 22, 2024 •

edited by ghost

Loading

ghost commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

allgandalf commented Mar 22, 2024 •

edited

Loading

bernhardoj commented Mar 23, 2024

tienifr commented Mar 23, 2024 •

edited

Loading

Ollyws commented Mar 24, 2024

melvin-bot bot commented Mar 24, 2024

bernhardoj commented Mar 25, 2024

Ollyws commented Mar 25, 2024

bernhardoj commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Apr 2, 2024

melvin-bot bot commented Apr 2, 2024

Ollyws commented Apr 9, 2024

Ollyws commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

Ollyws commented Apr 9, 2024 •

edited

Loading

joekaufmanexpensify commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824

[HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824

Comments

lanitochka17 commented Mar 22, 2024 • edited by melvin-bot bot Loading

Actual Result:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

github-actions bot commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

lanitochka17 commented Mar 22, 2024

iwiznia commented Mar 22, 2024

ahmedGaber93 commented Mar 22, 2024

ghost commented Mar 22, 2024 • edited by ghost Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

ghost commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

allgandalf commented Mar 22, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented Mar 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tienifr commented Mar 23, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Ollyws commented Mar 24, 2024

melvin-bot bot commented Mar 24, 2024

bernhardoj commented Mar 25, 2024

Ollyws commented Mar 25, 2024

bernhardoj commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

melvin-bot bot commented Apr 2, 2024

melvin-bot bot commented Apr 2, 2024

Ollyws commented Apr 9, 2024

Ollyws commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

Ollyws commented Apr 9, 2024 • edited Loading

joekaufmanexpensify commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

joekaufmanexpensify commented Apr 9, 2024

lanitochka17 commented Mar 22, 2024 •

edited by melvin-bot bot

Loading

ghost commented Mar 22, 2024 •

edited by ghost

Loading

allgandalf commented Mar 22, 2024 •

edited

Loading

tienifr commented Mar 23, 2024 •

edited

Loading

Ollyws commented Apr 9, 2024 •

edited

Loading