Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-05] Support light mode on help.expensify.com and match user's system preferences #37911

Closed
sakluger opened this issue Mar 7, 2024 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@sakluger
Copy link
Contributor

sakluger commented Mar 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Slack conversation: https://expensify.slack.com/archives/C02QSAC6BJ8/p1709831844030329

Problem

Our help site (help.expensify.com) contains many large blocks of text. Currently we only support dark mode for the help site, but it's difficult for many people (including me) to read large blocks of light text on a dark background. Here's an example of what this looks like today:

image

Proposed solution

Let's support light mode on our help site. Instead of adding a togglable setting, we can just match the user's system preferences for light mode vs dark mode.

@shawnborton gives some suggestions and advice around implementation in the Slack thread.

@sakluger sakluger added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@rushatgabhane
Copy link
Member

rushatgabhane commented Mar 11, 2024

Support for CSS prefers-color-scheme looks good. Going forward with it https://caniuse.com/prefers-color-scheme

image

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 21, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title Support light mode on help.expensify.com and match user's system preferences [HOLD for payment 2024-04-05] Support light mode on help.expensify.com and match user's system preferences Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Copy link

melvin-bot bot commented Apr 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@sakluger)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@sakluger
Copy link
Contributor Author

sakluger commented Apr 8, 2024

Looks great, thanks again @rushatgabhane! Feel free to request via NewDot using the payment summary above.

@sakluger sakluger closed this as completed Apr 8, 2024
@melvin-bot melvin-bot bot removed Overdue labels Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants