-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-05] Support light mode on help.expensify.com and match user's system preferences #37911
Comments
Triggered auto assignment to @Christinadobrzyn ( |
|
Support for CSS prefers-color-scheme looks good. Going forward with it https://caniuse.com/prefers-color-scheme ![]() |
Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@sakluger)
|
Looks great, thanks again @rushatgabhane! Feel free to request via NewDot using the payment summary above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Slack conversation: https://expensify.slack.com/archives/C02QSAC6BJ8/p1709831844030329
Problem
Our help site (help.expensify.com) contains many large blocks of text. Currently we only support dark mode for the help site, but it's difficult for many people (including me) to read large blocks of light text on a dark background. Here's an example of what this looks like today:
Proposed solution
Let's support light mode on our help site. Instead of adding a togglable setting, we can just match the user's system preferences for light mode vs dark mode.
@shawnborton gives some suggestions and advice around implementation in the Slack thread.
The text was updated successfully, but these errors were encountered: