[$500] [HOLD for payment 2024-04-03] [Simplified Collect][Taxes] Create WorkspaceEditTaxPage

[luacmartins]

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

Issue Owner

Current Issue Owner: @jliexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e446073ea5b5a4e
• Upwork Job ID: 1775735005542027264
• Last Price Increase: 2024-04-04

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[kosmydel]

Hey, I will take care of this issue.

I've prepared a draft PR of it. I will continue to work on this when the SetPolicyTaxesEnabled command is deployed on the backend.

[garrettmknight]

Off hold now that the other issue is on prod.

[DylanDylann]

@luacmartins Could I take over this one?

[mountiny]

@DylanDylann you mean as a C+

[DylanDylann]

@mountiny Yeah, because I have reviewed other pages of tax feature

[mountiny]

Thats reasonable, assign you

[jliexpensify]

Hello, I am OOO from 21st to 31st March. I won't assign this to another B0 member, as I think during this period, there are likely no actions for me to take, right?

[mountiny]

Sounds good

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Simplified Collect][Taxes] Tax editing and bulk actions #38208

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

There were 4 pages which were fixed in here, I suggest paying $500 to @DylanDylann for the review cc @luacmartins @trjExpensify of #38208

[trjExpensify]

Sounds good to me!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e446073ea5b5a4e

[jliexpensify]

Payment Summary

• C+: @DylanDylann $500 (as per this comment)

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

@DylanDylann have invited you here

[jliexpensify]

Waiting on @DylanDylann to accept. Also, any Regression Tests needed here?

[luacmartins]

No regression tests as part of this issue, we're adding it as part of the project instead.

[jliexpensify]

Paid and job closed!