Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-19] [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRatesPage #37510

Closed
luacmartins opened this issue Feb 29, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 29, 2024

Implement PolicyDistanceRatesPage following the specifications in the design doc

cc @MrMuzyk

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017bc3efd271014d5a
  • Upwork Job ID: 1763222628061282304
  • Last Price Increase: 2024-02-29
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
@luacmartins luacmartins self-assigned this Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Feb 29, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017bc3efd271014d5a

@melvin-bot melvin-bot bot changed the title [Simplified Collect][Distance Rates] Implement PolicyDistanceRatesPage [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRatesPage Feb 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Current assignee @anmurali is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 29, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@luacmartins luacmartins moved this to Release 2: From Setup > Export in [#whatsnext] Wave 08 - Collect Plan Admins Mar 5, 2024
@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@anmurali, @luacmartins, @MrMuzyk, @getusha Eep! 4 days overdue now. Issues have feelings too...

@anmurali
Copy link

anmurali commented Mar 5, 2024

MrMuzyk is working on this, not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRatesPage [HOLD for payment 2024-03-19] [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRatesPage Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-19. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @getusha requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 12, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 18, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Payment Summary

Upwork Job

  • Contributor: @MrMuzyk is from an agency-contributor and not due payment
  • ROLE: @getusha paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1763222628061282304/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2024
@anmurali
Copy link

@getusha - can you pls complete the BZ checklist and accept the offer

@melvin-bot melvin-bot bot removed the Overdue label Mar 21, 2024
@getusha
Copy link
Contributor

getusha commented Mar 24, 2024

@anmurali i think this doesn't need a regression test since it is a new feature #37311 (comment)

@luacmartins
Copy link
Contributor Author

Correct, we'll add those to testrail when we wrap up the project

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@luacmartins
Copy link
Contributor Author

Only pending payment

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@anmurali
Copy link

anmurali commented Apr 2, 2024

Waiting on @getusha to accept the offer. Still shows pending on my dashboard on Upwork.

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@anmurali, @luacmartins, @MrMuzyk, @getusha Eep! 4 days overdue now. Issues have feelings too...

@getusha
Copy link
Contributor

getusha commented Apr 8, 2024

@anmurali accepted

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@anmurali
Copy link

anmurali commented Apr 9, 2024

Paid

@anmurali anmurali closed this as completed Apr 9, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

4 participants