Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID - Ready for Manual Request] [$500][Simplified Collect][Tags] Create CreateWorkspaceTagPage #37311

Closed
luacmartins opened this issue Feb 27, 2024 · 29 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 27, 2024

Implement this section of the Simplified Collect: Tags design doc

cc @waterim

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011399a14d19af6df5
  • Upwork Job ID: 1762499866140581888
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • ishpaul777 | Reviewer | 0
Issue OwnerCurrent Issue Owner: @strepanier03
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@luacmartins luacmartins self-assigned this Feb 27, 2024
@luacmartins luacmartins moved this to Release 2: From Setup > Export in [#whatsnext] Wave 08 - Collect Plan Admins Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@waterim
Copy link
Contributor

waterim commented Feb 27, 2024

Hello, Im Artem from Callstack and would like to take this one

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 27, 2024
@melvin-bot melvin-bot bot changed the title [HOLD #37309][Simplified Collect][Tags] Create CreateWorkspaceTagPage [$500] [HOLD #37309][Simplified Collect][Tags] Create CreateWorkspaceTagPage Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011399a14d19af6df5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

Copy link

melvin-bot bot commented Feb 27, 2024

Current assignee @zanyrenney is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 27, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 29, 2024
@zanyrenney
Copy link
Contributor

On HOLD but @waterim on standby to pick it up

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@luacmartins, @waterim, @zanyrenney, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

On hold while we work on the main page

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@luacmartins
Copy link
Contributor Author

Yes, we already have a PR up for this 😄

Copy link

melvin-bot bot commented Mar 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot changed the title [$500][Simplified Collect][Tags] Create CreateWorkspaceTagPage [HOLD for payment 2024-03-22] [$500][Simplified Collect][Tags] Create CreateWorkspaceTagPage Mar 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@zanyrenney
Copy link
Contributor

Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to just finish this off for the payment.

@zanyrenney zanyrenney removed their assignment Mar 21, 2024
@zanyrenney zanyrenney added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 21, 2024
Copy link

melvin-bot bot commented Mar 21, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 21, 2024
@zanyrenney zanyrenney self-assigned this Mar 21, 2024
@strepanier03
Copy link
Contributor

@allroundexperts @ishpaul777 - Doesn't look like we need the checklist since this was a new feature, is that right?

I'm posting the payment summary below and once I have confirmation from you about the checklist I'll assign Jason for the manual request.

@strepanier03
Copy link
Contributor

strepanier03 commented Mar 22, 2024

Payment summary

@JmillsExpensify - Payment request incoming shortly.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Mar 22, 2024

Doesn't look like we need the checklist since this was a new feature, is that right?

correct! Regression tests will be added once the full [Simplified Collect] is completed

cc @luacmartins

@luacmartins
Copy link
Contributor Author

Correct!

@strepanier03
Copy link
Contributor

Fanastic. Thanks for confirming.

I'll assign this to Jason and mark it ready for payment. @allroundexperts feel free to submit your request for payment as soon as you can.

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 22, 2024
@strepanier03 strepanier03 changed the title [HOLD for payment 2024-03-22] [$500][Simplified Collect][Tags] Create CreateWorkspaceTagPage [PAID - Ready for Manual Request] [$500][Simplified Collect][Tags] Create CreateWorkspaceTagPage Mar 22, 2024
@JmillsExpensify
Copy link

$500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

8 participants