[HOLD for payment 2024-03-11] [$500] Collect approver - Settling up bank account message is not copied via Copy to clipboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4211927
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• Admin and employee are part of Collect workspace on Old Dot
• Admin has a verified bank account set up on Old Dot
• Employee does not have a bank account set up

1. [Employee] Request money from the workspace chat
2. [Admin] Approve the request
3. [Employee] Click on the expense preview to go to expense report
4. [Employee] Right click on the settling up bank account message > Copy to clipboard
5. [Employee] Paste the content

Expected Result:

The "settling up bank account" message is copied via Copy to clipboard

Actual Result:

The "settling up bank account" message is not copied via Copy to clipboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6352402_1706036789246.bandicam_2024-01-23_03-34-38-511.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0180d89c40563c1127
• Upwork Job ID: 1749875151051063296
• Last Price Increase: 2024-01-23
• Automatic offers:
• FitseTLT | Contributor | 28122433

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0180d89c40563c1127

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[lanitochka17]

We think that this bug might be related to #wave7.
CC @RachCHopkins

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Collect approver - Settling up bank account message is not copied via Copy to clipboard

What is the root cause of that problem?

We set it to the email address.

App/src/pages/workspace/reimburse/WorkspaceReimburseView.js

Lines 125 to 128 in bb86e24

	<CopyTextToClipboard
	text={CONST.EMAIL.RECEIPTS}
	textStyles={[styles.textBlue]}
	/>

What changes do you think we should make in order to solve the problem?

change it to copy the text

What alternative solutions did you explore? (Optional)

N/A

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Collect approver - Settling up bank account message is not copied via Copy to clipboard

What is the root cause of that problem?

We don't have a logic handling for REIMBURSEMENTQUEUED in here

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 378 to 380 in 74f1163

	const content = selection || messageHtml;
	if (isReportPreviewAction) {
	const iouReport = ReportUtils.getReport(ReportActionsUtils.getIOUReportIDFromReportActionPreview(reportAction));

What changes do you think we should make in order to solve the problem?

We need to add a condition that will handle for REIMBURSEMENTQUEUED case and set the clipboard to the same message that we are displaying in the ReportActionItem here

App/src/pages/home/report/ReportActionItem.js

Lines 395 to 409 in 74f1163

	} else if (props.action.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENTQUEUED) {
	const submitterDisplayName = PersonalDetailsUtils.getDisplayNameOrDefault(lodashGet(personalDetails, props.report.ownerAccountID));
	const paymentType = lodashGet(props.action, 'originalMessage.paymentType', '');
	const isSubmitterOfUnsettledReport = ReportUtils.isCurrentUserSubmitter(props.report.reportID) && !ReportUtils.isSettled(props.report.reportID);
	const shouldShowAddCreditBankAccountButton = isSubmitterOfUnsettledReport && !store.hasCreditBankAccount() && paymentType !== CONST.IOU.PAYMENT_TYPE.EXPENSIFY;
	const shouldShowEnableWalletButton =
	isSubmitterOfUnsettledReport &&
	(_.isEmpty(props.userWallet) || props.userWallet.tierName === CONST.WALLET.TIER_NAME.SILVER) &&
	paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY;
	children = (
	<ReportActionItemBasicMessage
	message={props.translate(paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY ? 'iou.waitingOnEnabledWallet' : 'iou.waitingOnBankAccount', {submitterDisplayName})}
	>

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Collect approver - Settling up bank account message is not copied via Copy to clipboard

What is the root cause of that problem?

• We do not handle case the action is isReimbursementQueuedAction here

What changes do you think we should make in order to solve the problem?

• We need to handle the above case by adding the below condition to the logic:

 if (ReportActionsUtils.isReimbursementQueuedAction(reportAction)) {
                    const reimbursementQueuedActionMessage = ReportUtils.getReimbursementQueuedActionMessage(reportAction, report);
                    Clipboard.setString(reimbursementQueuedActionMessage);
                } else

What alternative solutions did you explore? (Optional)

• NA

[eVoloshchak]

@dukenv0307, correct me if I'm wrong, but your proposal is an extension of @FitseTLT's proposal, they share the same general idea
@FitseTLT's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[eVoloshchak]

Not overdue, PR is being drafted by @FitseTLT

[CortneyOfstad]

@FitseTLT any update on the PR draft? Thanks!

[FitseTLT]

Will make PR ready for review in 2 days

[CortneyOfstad]

@FitseTLT any update? Thanks!

[CortneyOfstad]

@eVoloshchak PR is ready for your eyes! TIA!

[CortneyOfstad]

@eVoloshchak @FitseTLT an update on the PR/review?

Also, @RachCHopkins they believe this fits into #Wave7 — can you confirm? Thanks!

[eVoloshchak]

No update, waiting for a response from @FitseTLT
PR is done and working, we need to finish up the PR author checklist

[eVoloshchak]

No update, looks like @FitseTLT is not around

[FitseTLT]

No update, looks like @FitseTLT is not around

Sorry for the delayed response @eVoloshchak will update PR shortly and notify u

[CortneyOfstad]

@eVoloshchak an update on the PR review? It looks like @FitseTLT bumped you a few hours ago. Do you think you can provide an update by EOD today? Thanks!

[CortneyOfstad]

Bump @eVoloshchak ^^^ Thanks!

[eVoloshchak]

Left a comment on the PR, apologies for the delay folks

[FitseTLT]

@eVoloshchak bump on the response I gave on the PR. If you still having trouble setting up please forward it and I can give more details 👍

[CortneyOfstad]

@eVoloshchak looks like @FitseTLT bumped you on the PR here 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Settling up bank account message is not copied via Copy to clipboard #36070

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payment Summary

@FitseTLT — paid $500 via Upwork
@eVoloshchak — to be paid $500 via NewDot

[CortneyOfstad]

@eVoloshchak can you please complete the checklist above? Thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: unable to pinpoint a PR that has caused the bug, this is a bit of logic that wasn't implemented initially
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this was missed since it is an edge case (see precondition), a regression test will be sufficient

[eVoloshchak]

Regression Test Proposal

Preconditions:

• Admin and employee are part of Collect workspace on Old Dot
• Admin has a verified bank account set up on Old Dot
• Employee does not have a bank account set up

Test steps:

1. [Employee] Request money from the workspace chat
2. [Admin] Approve the request
3. [Employee] Click on the expense preview to go to expense report
4. [Employee] Right click on the settling up bank account message > Copy to clipboard
5. [Employee] Paste the content

Do we agree 👍 or 👎

[francoisl]

I opened an issue to create the regression tests, so feel free to issue the payments and then close this @CortneyOfstad

[CortneyOfstad]

Sounds good @francoisl! Payment has already been issued, with the payment summary listed here, so we're good to close!

[JmillsExpensify]

$500 approved for @eVoloshchak based on this summary.