Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32187

Closed
rezkiy37 opened this issue Nov 29, 2023 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@rezkiy37
Copy link
Contributor

Background

We already implemented the referral program. However, there is a request to change UI.

What to add and where to add it

Redesign ReferralDetailsPage.js

What it should look and act like

image

@rezkiy37 rezkiy37 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@rezkiy37
Copy link
Contributor Author

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor Author

Actively working on the issue. Also, I have a question how to place additional content that was implemented here?

https://staging.new.expensify.com/referral/shareCode

Screenshot 2023-11-30 at 16 57 40

@jamesdeanexpensify
Copy link
Contributor

Chatting here.

@rezkiy37
Copy link
Contributor Author

rezkiy37 commented Dec 1, 2023

Preparing a draft PR.

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@rezkiy37
Copy link
Contributor Author

rezkiy37 commented Dec 4, 2023

Waiting for answer on a comment in the PR.

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@rezkiy37
Copy link
Contributor Author

rezkiy37 commented Dec 5, 2023

Discussing internally here.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 6, 2023
@parasharrajat
Copy link
Member

Handling as C+. cc: @CortneyOfstad

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@CortneyOfstad
Copy link
Contributor

Any updates on the PR? TIA!

@rezkiy37
Copy link
Contributor Author

It was merged.

@rezkiy37
Copy link
Contributor Author

Guys, I am having a vacation till the 4th January. So, I will be OOO within this period.

@parasharrajat
Copy link
Member

@CortneyOfstad PR was deployed to prod on 14 Dec #32362. It's ready for payment summary. Then we can close it.

@CortneyOfstad
Copy link
Contributor

Sorry, was OoO for the holidays — getting the payment summary together now!

@CortneyOfstad
Copy link
Contributor

Needed clarification on payment amount, so asked internally here. Will follow-up ASAP

@CortneyOfstad
Copy link
Contributor

Alright, got confirmation! Breakdown below:

Payment Summary

@parasharrajat to be paid $500 via NewDot as C+
@rezkiy37 is from CallStack, so no payment details needed at this time

@parasharrajat
Copy link
Member

Payment requested as per #32187 (comment)

@JmillsExpensify
Copy link

$500 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants