Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] [TS migration] Migrate 'IOUEditRequest' page to TypeScript #32002

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 31 comments
Closed

[HOLD] [$250] [TS migration] Migrate 'IOUEditRequest' page to TypeScript #32002

melvin-bot bot opened this issue Nov 27, 2023 · 31 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/EditRequestTagPage.js 9
src/pages/EditRequestPage.js 31
src/pages/EditRequestMerchantPage.js 12
src/pages/EditRequestDistancePage.js 18
src/pages/EditRequestDescriptionPage.js 15
src/pages/EditRequestCreatedPage.js 9
src/pages/EditRequestCategoryPage.js 9
src/pages/EditRequestAmountPage.js 9
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01782b82647cf209ce
  • Upwork Job ID: 1750843254678204416
  • Last Price Increase: 2024-01-26
@filip-solecki
Copy link
Contributor

Hey! I’m Filip Solecki from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2023
Copy link
Author

melvin-bot bot commented Dec 20, 2023

📣 @filip-solecki! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@abzokhattab
Copy link
Contributor

I can work on this

@melvin-bot melvin-bot bot added the Overdue label Jan 26, 2024
@dummy-1111
Copy link
Contributor

Dibs

@melvin-bot melvin-bot bot removed the Overdue label Jan 26, 2024
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Overdue labels Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'IOUEditRequest' page to TypeScript [$500] [TS migration] Migrate 'IOUEditRequest' page to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01782b82647cf209ce

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Monthly KSv2 labels Jan 26, 2024
@mountiny mountiny removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 26, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Feb 7, 2024

Bumped the MoneyRequestAmountForm PR hopefully we'll have a ETA for that soon

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@ishpaul777
Copy link
Contributor

not overdue, we are still holding

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@ishpaul777
Copy link
Contributor

not overdue, we are still holding

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@ishpaul777
Copy link
Contributor

@filip-solecki Can you please update whats the status here?

@melvin-bot melvin-bot bot removed the Overdue label Mar 8, 2024
@filip-solecki
Copy link
Contributor

Only TagPicker left from blockers, so I think it is possible to start work on this in a few days

@filip-solecki
Copy link
Contributor

If I am correct it is now merged too, I will start working on this migration asap

@war-in
Copy link
Contributor

war-in commented Mar 19, 2024

Hey! I’m Marcin Warchoł from Software Mansion, an expert agency, and I’d like to take over this issue

@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2024
Copy link
Author

melvin-bot bot commented Mar 19, 2024

📣 @war-in! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@ishpaul777
Copy link
Contributor

not overdue @war-in from SWM will start working on it soon

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
@fabioh8010
Copy link
Contributor

Hey @ishpaul777 @war-in let's not migrate this one, the remaining files are going to be removed soon.

@war-in
Copy link
Contributor

war-in commented Mar 22, 2024

Thanks for letting us know @fabioh8010! Should the issue be closed as not planned now?

@fabioh8010
Copy link
Contributor

Yeah, let's close it!

@war-in
Copy link
Contributor

war-in commented Mar 22, 2024

Do you know who should be tagged here to do so? (I don't have such an option :/)

@ishpaul777
Copy link
Contributor

@MitchExpensify ⬆️ We can put up a hold instead of closing

@MitchExpensify MitchExpensify changed the title [$250] [TS migration] Migrate 'IOUEditRequest' page to TypeScript [HOLD] [$250] [TS migration] Migrate 'IOUEditRequest' page to TypeScript Mar 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@MitchExpensify
Copy link
Contributor

On hold, waiting on @war-in to pick this up

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@war-in
Copy link
Contributor

war-in commented Apr 3, 2024

@MitchExpensify should I pick this up or leave it as is?

@fabioh8010 wrote

let's not migrate this one, the remaining files are going to be removed soon.

@MitchExpensify
Copy link
Contributor

Oh thanks for the catch @war-in, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

8 participants