[HOLD for payment 2023-12-26] [$500] Wallet - Button to confirm bank account deletion is off-screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must be logged in and must have added a BA to the wallet

1. Click on Settings
2. Click on "Wallet"
3. Click on the added BA
4. Click on "Delete" button

Expected Result:

Button to confirm back account deletion should be on-screen, allowing the user to click on it

Actual Result:

Button to confirm back account deletion is off-screen, so the user cannot click on it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6239802_1697496693646.bandicam_2023-10-16_17-38-16-495.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181bf24251c643efc
• Upwork Job ID: 1714219098497863680
• Last Price Increase: 2023-10-31
• Automatic offers:
• neonbhai | Contributor | 27462333

Issue Owner

Current Issue Owner: @Santhosh-Sellavel

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Confirm Modal is anchored to the account row rendering parts of it offscreen.

What is the root cause of that problem?

We render the confirm content here:

App/src/pages/settings/Wallet/WalletPage/WalletPage.js

Line 459 in c5a5244

<ConfirmContent

This is anchored to the Bank Account Row. Since the bank account element is near the bottom of screen, the popover when taking it as an anchor gets rendered offscreen.

What changes do you think we should make in order to solve the problem?

We always show confirm actions with danger buttons as a screen centered modal. Deleting a bank account is also an important action that should be confirmed with a modal in the center of the screen.

We should simply use the Confirm Modal component to render the confirm popover:

Replace:

App/src/pages/settings/Wallet/WalletPage/WalletPage.js

Lines 459 to 476 in c5a5244

	<ConfirmContent
	onConfirm={() => {
	deletePaymentMethod();
	hideDefaultDeleteMenu();
	}}
	onCancel={hideDefaultDeleteMenu}
	contentStyles={!isSmallScreenWidth ? [styles.sidebarPopover, styles.willChangeTransform] : undefined}
	title={translate('walletPage.deleteAccount')}
	prompt={translate('walletPage.deleteConfirmation')}
	confirmText={translate('common.delete')}
	cancelText={translate('common.cancel')}
	anchorPosition={{
	top: anchorPosition.anchorPositionTop,
	right: anchorPosition.anchorPositionRight,
	}}
	shouldShowCancelButton
	danger
	/>

With:

<ConfirmModal
    isVisible
    onConfirm={() => {
        deletePaymentMethod();
        hideDefaultDeleteMenu();
    }}
    onCancel={hideDefaultDeleteMenu}
    contentStyles={!isSmallScreenWidth ? [styles.sidebarPopover, styles.willChangeTransform] : undefined}
    title={translate('walletPage.deleteAccount')}
    prompt={translate('walletPage.deleteConfirmation')}
    confirmText={translate('common.delete')}
    cancelText={translate('common.cancel')}
    anchorPosition={{
        top: anchorPosition.anchorPositionTop,
        right: anchorPosition.anchorPositionRight,
    }}
    shouldShowCancelButton
    danger
/>

It wraps the content in a Modal and displays it in the center of the screen.

Result:

Screencast.from.17-10-23.10.05.44.AM.IST.webm

Screencast.from.17-10-23.10.06.20.AM.IST.webm

Cancel Task Popover

We will be adding a trigger to show the confirmation modal here:

App/src/pages/home/HeaderView.js

Line 116 in a8482e2

onSelected: Session.checkIfActionIsAllowed(() => Task.cancelTask(props.report.reportID, props.report.reportName, props.report.stateNum, props.report.statusNum)),

and carry out the action when it is confirmed from the modal.

What alternative solutions did you explore? (Optional)

We can refactor the WalletPage and render ConfirmModal outside of <Popover>. We will set the isVisible prop conditionally when showConfirmDeleteContent is true.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0181bf24251c643efc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Victor-Nyagudi]

Judging by just how big the text is in the RHP of the attached video, I think the tester may have just been zoomed in too much.

The button to confirm a bank account deletion appears where it should be for me (regular 100% zoom level).

expensify-delete-bank-account-flow.mov

Maybe they could double check and share with us their zoom level to see if we can reproduce the bug.

[Santhosh-Sellavel]

@Victor-Nyagudi Try to resize the browser in a way bottom has less spacing to show the modal.

Screen.Recording.2023-10-18.at.1.43.05.AM.mov

[Santhosh-Sellavel]

@Expensify/design What can we do here?
Please share thoughts on this proposal.

[shawnborton]

cc @pac-guerreiro can you follow up and fix this one? We shouldn't open this up as a bug, but rather it can be fixed as a follow up to the work you are doing here. cc @grgia

In terms of how to fix, I would think we just detect how close to the bottom of the viewport we are, and if we are too close, we launch the popover above the button.

[Santhosh-Sellavel]

bump @pac-guerreiro or @grgia

[neonbhai]

Suggesting to show with an overlay since we always confirm with a modal when an action is important. This would also be an inconsistency 🤔

We should show it in the middle of screen, similar to how we confirm other actions taken in the app:

• Deletion of workspace:

  Screencast.from.21-10-23.07.50.06.AM.IST.webm

• Disabling 2FA:

  Screencast.from.21-10-23.07.56.05.AM.IST.webm

• Reset Bank Account Steps:

  Screencast.from.21-10-23.09.00.14.AM.IST.webm

Whereas, confirming popover in this flow appears in the RHN itself:

Screencast.from.23-10-23.09.42.38.AM.IST.webm

Creating an inconsistency.

cc: @shawnborton @Santhosh-Sellavel

[grgia]

Before deciding how to move forward, I'm curious your thoughts on #29729 (comment) @shawnborton. I agree, it's interesting that we use a different pattern on this page. Was that intentional or should we change to use the overlay modal?

[shawnborton]

Yeah, I would think we should make them all use the center alert modal style (which is a bottom-docked modal on mobile)

[dannymcclain]

Agree with Shawn—I think they should be consistent and use the center alert modal.

[Santhosh-Sellavel]

not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

@pac-guerreiro just following up here - can you take on this one?

[neonbhai]

We are also missing a confirmation popover when we cancel a task. Considering this is an irreversible action and closes a report, we should add a confirmation here:

cancel.task.webm

This line should trigger the popover, and on confirming we should carry out the onSelected function

[neonbhai]

Proposal

Updated

Requesting for permission to work on this. Consider as this was identified as an inconsistency in the app explained here and I have posted the detailed root causes and solution here and here.

cc: @shawnborton @laurenreidexpensify

[neonbhai]

Are we good to have this text and the prompt in the Cancel Task confirm modal:

Video

69ee675a-2aef-4738-afc5-62011ab5efd3.mp4

cc: @dubielzyk-expensify @shawnborton

[shawnborton]

Looks good to me

[Santhosh-Sellavel]

@laurenreidexpensify Can you confirm the newly added copies are good?

En

 cancelTask: 'Cancel task',
 cancelConfirmation: 'Are you sure that you want to cancel this task?',

Es

 cancelTask: 'Cancelar tarea',
 cancelConfirmation: '¿Estás seguro de que quieres cancelar esta tarea?',

[Santhosh-Sellavel]

bump @laurenreidexpensify

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Popover Fixes #30882

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @Santhosh-Sellavel requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@jasperhuangg, @laurenreidexpensify, @neonbhai, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[laurenreidexpensify]

Payment Summary:

Contributor: @neonbhai $500 payment issued in Upwork
C+: @Santhosh-Sellavel $500 please request payment in Newdot

Remaining Steps to Close: @Santhosh-Sellavel to complete checklist

[laurenreidexpensify]

Not overdue Melv

[melvin-bot]

@jasperhuangg, @laurenreidexpensify, @neonbhai, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@jasperhuangg, @laurenreidexpensify, @neonbhai, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Santhosh-Sellavel]

We can skip the checklist as it ended up as UI Polish i.e became an improvement eliminating rare bug as well., as we unified confirm actions on this page with center alert modal style following this #29729 (comment)

cc: @jasperhuangg @laurenreidexpensify

[jasperhuangg]

Thanks @Santhosh-Sellavel! Does that mean we're good to close this out? Payment has been issued.

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 payment approved for @Santhosh-Sellavel based on this comment.