Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-03] [TS migration] Migrate 'OptionRow.stories.js' story to TypeScript #25350

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/stories/OptionRow.stories.js 4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018e7ef2c6e9f1f084
  • Upwork Job ID: 1775936901493862400
  • Last Price Increase: 2024-04-04
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Mar 20, 2024

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 20, 2024
Copy link
Author

melvin-bot bot commented Mar 20, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 27, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'OptionRow.stories.js' story to TypeScript [HOLD for payment 2024-04-03] [TS migration] Migrate 'OptionRow.stories.js' story to TypeScript Mar 27, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 27, 2024
Copy link
Author

melvin-bot bot commented Mar 27, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 27, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-03. 🎊

Copy link
Author

melvin-bot bot commented Mar 27, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@yuwenmemon] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ishpaul777
Copy link
Contributor

hey @yuwenmemon @sakluger i reviewed the PR #25350 for this one Can i be assigned to issue for payment

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Apr 4, 2024
Copy link
Author

melvin-bot bot commented Apr 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018e7ef2c6e9f1f084

Copy link
Author

melvin-bot bot commented Apr 4, 2024

Current assignee @ishpaul777 is eligible for the Internal assigner, not assigning anyone new.

@sakluger
Copy link
Contributor

sakluger commented Apr 4, 2024

@ishpaul777 I sent you an offer in Upwork: https://www.upwork.com/nx/wm/offer/101737301/

@ishpaul777
Copy link
Contributor

ishpaul777 commented Apr 4, 2024 via email

@sakluger
Copy link
Contributor

sakluger commented Apr 4, 2024

Thanks! All paid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants