[HOLD for payment 2023-09-20] [$1000] mWeb - Topbar color is different in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Check the top bar of LHN

Expected Result:

Top bar colour should not be different on the sign up/in page.

Actual Result:

Top bar colour is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689856723308669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107562926acd531ac
• Upwork Job ID: 1689496626413031424
• Last Price Increase: 2023-08-17
• Automatic offers:
• niravkakadiya25 | Reporter | 26295148

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alitoshmatov]

I think it is matching background color of the chat

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The topbar colour does not match on login screen

What is the root cause of that problem?

The root cause of the issue is that when the page is loaded, the onStateChange callback is not triggered here. This callback calls animateStatusBarBackgroundColor which is responsible for setting the correct top bar colour. By default, we're just using themeColors.appBG as the top bar colour which works when the user is logged in ie LHN uses this as the background colour.

What changes do you think we should make in order to solve the problem?

We need to trigger animateStatusBarBackgroundColor function once the NavigationRoot is mounted and navigation is ready ie add here in a effect:

  Navigation.isNavigationReady().then(() => {
      animateStatusBarBackgroundColor();
   });

What alternative solutions did you explore? (Optional)

In SignInPageLayout / PublicScreens component, we can define and call animateStatusBarBackgroundColor function with the correct background colour.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[mallenexpensify]

@shawnborton do know what expected behaviour is here? I checked on new.dot and staging in Safari and, once signed in, the colors seem to match at the top.

[shawnborton]

Yeah, we should update the color to match the page BG here.

[shawnborton]

Seems like it works fine if you are signed in, but the problem is the sign up/in page.

[shawnborton]

Not overdue. This is something we should fix. @mallenexpensify can you take it from here please? Thanks!

[melvin-bot]

@shawnborton, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@shawnborton @mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@shawnborton, @mallenexpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@shawnborton, @mallenexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0107562926acd531ac

[allroundexperts]

PR created #25908

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: maintain consistent topbar colour on login #25908

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
• @niravkakadiya25 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Issue reporter: @niravkakadiya25 paid $250 via Upwork
Contributor: @allroundexperts owed $500 via NewDot
Contributor+: @Santhosh-Sellavel owed $500 via NewDot.
Updated below

50% reduction in pay due to time between hiring and PR being merged.

@allroundexperts please complete the BZ checklist above

[allroundexperts]

@mallenexpensify Can you please check the days again? This remained on hold for sometime because of the merge freeze.

[mallenexpensify]

@allroundexperts, this one is a lil tricky, the issue was put on hold on 9/4 by Vit, so the best case scenario is ~7 biz days from hire to merge, if he would have done it then

And... according to CONTRIBUTING.md

• Merged PR within 9 business days (216 hours) - 50% penalty

So... I think your argument/consideration holds weight. @mountiny do you agree?

[mountiny]

@mallenexpensify in this case I agree that the penalty should not be put in place, we were not adding the bonuses and same should go for penalties so I would do the full price here

[melvin-bot]

@mallenexpensify, @allroundexperts, @mountiny, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Issue reporter: @niravkakadiya25 paid $250 via Upwork
Contributor: @allroundexperts owed $1000 via NewDot
Contributor+: @Santhosh-Sellavel owed $1000 via NewDot.

Updated based on Vit's comment above

Thanks @mountiny

[JmillsExpensify]

$1,000 payment approved for @allroundexperts based on BZ summary.

[JmillsExpensify]

$1,000 payment approved for @Santhosh-Sellavel based on BZ summary.