[HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Typing feedback text under composer is not being displayed

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a tab where account A is signed in
2. Open an existing chat with account B
3. Start typing in composer

Expected Result:

Account B should be able to see account A is typing feedback under composer

Actual Result:

account A is typing feedback is not displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-07.16.22.16.mp4

Recording.1211.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688736356072589

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Typing indicator doesn't show under composer

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsView.js

Lines 243 to 246 in ed21fda

	if (!didSubscribeToReportTypingEvents && didCreateReportSuccessfully) {
	Report.subscribeToReportTypingEvents(props.report.reportID);
	didSubscribeToReportTypingEvents.current = true;
	}

As didSubscribeToReportTypingEvents is useRef hook, if condition is always false and thus never subscribed.

What changes do you think we should make in order to solve the problem?

replace didSubscribeToReportTypingEvents with didSubscribeToReportTypingEvents.current in if condition

[situchan]

I can raise quick PR for this fix. cc: @neil-marcellini @narefyev91

[hungvu193]

Can't reproduce on latest dev.

[Pujan92]

Seems a regression from #22200

[rayane-d]

PR ready for review. @srikarparsi @flaviadefaria @Santhosh-Sellavel

[Santhosh-Sellavel]

Review done waiting for a CME to merge!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/22200/files
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Migrate ReportActionsView.js to function component #22200 (comment)
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1689207837567659
• [@srikarparsi] Determine if we should create a regression test for this bug. I don't believe one is needed
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Typing feedback text under composer is not being displayed #22501

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@srikarparsi] Determine if we should create a regression test for this bug.
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

I just want to confirm who needs payment here as I see no C+ or contributor assigned to the GH.

@Natnael-Guchima $250
@rayane-djouah $1000 + $500 bonus = $1500
@Santhosh-Sellavel $1000 + $500 bonus = $1500

Does this look correct @srikarparsi?

[situchan]

This was a regression from #22200. Otherwise my proposal would have been accepted as I proposed first.

[Santhosh-Sellavel]

@flaviadefaria Right this is a regression so @rayane-djouah will not be eligible for compensation here. Only reporter and myself for the review as this is a deploy blocker. So I've reviewed the PR keep this moving forward.

[flaviadefaria]

Got it. So in this case, should there be a 50% bonus for you or does it not apply?

[Santhosh-Sellavel]

@flaviadefaria Honestly I'm not sure, never been in this scenario before. Mostly it would be internal PRs, this is the odd one can you please check internally?

Worst case fine with No bonus as well, thanks!

[Santhosh-Sellavel]

@flaviadefaria Please assign me this, let me know the final amount. I'll request on ND!

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR: Migrate ReportActionsView.js to function component #22200
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Migrate ReportActionsView.js to function component #22200 (comment)
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@srikarparsi] Determine if we should create a regression test for this bug. We will have this covered already
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

Thanks!

So @Natnael-Guchima $250
@Santhosh-Sellavel $1000

@Santhosh-Sellavel you are going to request payment vua NewDot right? @Natnael-Guchim I'll process your payment in Upworks now.

[flaviadefaria]

@Natnael-Guchima offer sent!

[Natnael-Guchima]

Accepted the offer. Thanks @flaviadefaria

[flaviadefaria]

@Natnael-Guchima - paid
@Santhosh-Sellavel - I just assigned you. The correct amount to be requested is $1000.

[Santhosh-Sellavel]

Requested on ND

[flaviadefaria]

@Santhosh-Sellavel - I just assigned you. The correct amount to be requested is $1000.

Cool waiting for Anu to pay this so that we can close this.

[JmillsExpensify]

Reviewed details for @Santhosh-Sellavel. This is accurate and approved for payment in NewDot.

[flaviadefaria]

Great so closing this GH.