[HOLD for payment 2023-07-14] [$1000] Task checkbox state incorrect for unassigned user in chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to NewDot on Chrome web with User A
2. User A creates a task within a chat with User B, assigned to User A
3. User A completes the task
4. User B signs in and opens the chat

Expected Result:

User B's chat should show the task with completed checkbox.

Actual Result:

User B sees the checkbox showing as if the task is still open.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

task-completion-state-two-users-2023-06-26_16.21.54.1.mp4

Recording.5235.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jjcoffee
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687789907864819

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170f32a7e598994e4
• Upwork Job ID: 1675756819447054336
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

From @jjcoffee.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users in the same chat should see the correct task status when they log in.

What is the root cause of that problem?

Users who are not assigned to a task do not have access to the taskReport itself, only the linked reportAction which shows the taskPreview.
We check for the task's completion state here:
https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/TaskPreview.js#L57-L59
The issue is that we are always using the taskReport since the taskReport prop will always be available, just empty in the case of the user not being assigned/having access to the taskReport.

What changes do you think we should make in order to solve the problem?

Update the conditional to check if the prop is empty, using .isEmpty:
const isTaskCompleted = !.isEmpty(props.taskReport)
? props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED
: props.action.childStateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.action.childStatusNum === CONST.REPORT.STATUS.APPROVED;

[jjcoffee]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users in the same chat should see the correct task status when they log in.

What is the root cause of that problem?

Users who are not assigned to a task do not have access to the taskReport itself, only the linked reportAction which shows the taskPreview.

We check for the task's completion state here:

App/src/components/ReportActionItem/TaskPreview.js

Lines 57 to 59 in 3404111

	const isTaskCompleted = props.taskReport
	? props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED
	: props.action.childStateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.action.childStatusNum === CONST.REPORT.STATUS.APPROVED;

The issue is that we are always using the taskReport since the taskReport prop will always be available, just empty in the case of the user not being assigned/having access to the taskReport.

What changes do you think we should make in order to solve the problem?

Update the conditional to check if the prop is empty, using _.isEmpty:

const isTaskCompleted = !_.isEmpty(props.taskReport)
	? props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED
	: props.action.childStateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.action.childStatusNum === CONST.REPORT.STATUS.APPROVED;

[kadiealexander]

Reproduced:

2023-07-03_18-41-03.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0170f32a7e598994e4

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[narefyev91]

Proposal from @jjcoffee looks good to me #21924 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account 🎉

Contributor - [$1000] Task checkbox state incorrect for unassigned user in chat Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account 🎉

Reporter - [$1000] Task checkbox state incorrect for unassigned user in chat

[jjcoffee]

PR coming today!

[jjcoffee]

PR ready! cc @narefyev91

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Ensure correct task state for fresh session of unassigned user #22171

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

I'm going OOO tomorrow for a long weekend so I need some help with payment on Friday!

@narefyev91 could you please make sure the checklist is complete, and let us know if you're being paid via NewDot?

[melvin-bot]

Triggered auto assignment to @muttmuure (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignee @narefyev91 is eligible for the External assigner, not assigning anyone new.

[kadiealexander]

Thanks for the help @muttmuure!!

[narefyev91]

I'm going OOO tomorrow for a long weekend so I need some help with payment on Friday!

@narefyev91 could you please make sure the checklist is complete, and let us know if you're being paid via NewDot?

Hey @kadiealexander I'm from Callstack - and no needs any additional payments :-)

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - Move task reportActions onto the task report #20014
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - https://github.com/Expensify/App/pull/20014/files#r1262063857
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussions
• Determine if we should create a regression test for this bug - we good to go with QA steps in the merged PR

[muttmuure]

@jjcoffee paid for reporting and urgency

[melvin-bot]

@jjcoffee, @narefyev91, @muttmuure, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[muttmuure]

Everyone is paid and no regression test. Closing