Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-06] Add Light Theme Illustrations to App and create Hook for Illustrations #21017

Closed
grgia opened this issue Jun 19, 2023 · 38 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Jun 19, 2023

https://docs.google.com/document/d/1KwVVu5-DLjmb-2-UwgIw5ElmyKn0ZXs8wUzxcNZjwDc/edit#bookmark=id.gdjmszsnmgj8

As part of this issue we will:

  • Upload the light mode assets
  • Create a useThemeIllustrations similar to useThemeStyles
  • Use the hook in the places where we currently use these assets
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dfe5b060f911b101
  • Upwork Job ID: 1684527012106264576
  • Last Price Increase: 2023-07-27
@Shivam7-1
Copy link

Hii
I am Interested In this Project as a Freelancer How can I Contribute in it?

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

📣 @Shivam7-1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Shivam7-1
Copy link

Contributor details
Your Expensify account email: shivam.tiwari00021@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01eb86a64553a3f6cd

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Shivam7-1
Copy link

How Should I contribute to project do I get assign or I have to direct work on PR

@grgia
Copy link
Contributor Author

grgia commented Jun 27, 2023

@Shivam7-1 if you're interested in contributing check out our jobs with the Help Wanted label here. For our theme switching project, we may be creating some external issues and adding the label, and you'll see them there!

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2023
@grgia
Copy link
Contributor Author

grgia commented Jul 7, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jul 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@grgia
Copy link
Contributor Author

grgia commented Jul 17, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2023
@grgia
Copy link
Contributor Author

grgia commented Jul 27, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2023
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dfe5b060f911b101

@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@grgia
Copy link
Contributor Author

grgia commented Jul 27, 2023

This won't require C+ Review, sorry for the ping @parasharrajat

@grgia
Copy link
Contributor Author

grgia commented Aug 16, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 25, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 28, 2023

not overdue

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Dec 5, 2023
@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 6, 2023
@dannymcclain

This comment was marked as outdated.

@dannymcclain
Copy link
Contributor

@grgia Sorry, our Figma variables weren't updated when I exported the previous check images. Here are the real updated check images for light and dark mode: UPDATED Example Check Images.zip

@dannymcclain
Copy link
Contributor

For posterity:
Transparent 800x192 Check Images.zip

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@dannymcclain
Copy link
Contributor

Not overdue Melvin. @grgia anything else you need from me for this?

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@grgia grgia closed this as completed Dec 13, 2023
@github-project-automation github-project-automation bot moved this from Done - Live ✅ to Merged in Theme Switching / Light Mode Dec 13, 2023
@shubham1206agra
Copy link
Contributor

@grgia Is this not eligible for payment?

@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 14, 2023
@grgia grgia reopened this Dec 18, 2023
@grgia grgia added the NewFeature Something to build that is a new item. label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 18, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 18, 2023

@Christinadobrzyn could you help me out with the $500 C+ Review payment to @shubham1206agra for #31452

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Dec 18, 2023

Payouts due:

Issue Reporter: NA
Contributor: NA
Contributor+: $500 @shubham1206agra (paid in Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

@shubham1206agra can you accept the job offer and I'll pay you through Upwork? (let me know if you are paid through NewExpensify instead)

@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Dec 18, 2023
@shubham1206agra
Copy link
Contributor

@Christinadobrzyn Offer accepted

@Christinadobrzyn
Copy link
Contributor

Awesome! thanks! I paid you in Upwork based on this payment summary #21017 (comment)

Closing!

@github-project-automation github-project-automation bot moved this from Done - Live ✅ to Merged in Theme Switching / Light Mode Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

7 participants