Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Migrate ReportScreen.js to function component #16255

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 38 comments
Closed
1 task

[$250] Migrate ReportScreen.js to function component #16255

marcaaron opened this issue Mar 20, 2023 · 38 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

  • src/pages/home/ReportScreen.js
    • type: React.Component
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidMount,componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0184e14afba16fa311
  • Upwork Job ID: 1686461318953848833
  • Last Price Increase: 2023-08-01
  • Automatic offers:
    • aimane-chnaif | Reviewer | 25887921
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate ReportScreen.js to function component [HOLD][$250] Migrate ReportScreen.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@marcaaron
Copy link
Contributor Author

@dayana7204 Kindly refrain from spamming all the issues that are on HOLD. Once they are off hold you will have an opportunity to apply.

@dayana7204
Copy link
Contributor

dayana7204 commented Jun 27, 2023 via email

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@to-ai
Copy link

to-ai commented Jul 11, 2023

I am able to work on this task.

@ghost
Copy link

ghost commented Jul 14, 2023

Dibs

@pradeepmdk
Copy link
Contributor

i will work on this

@SosenWiosen
Copy link
Contributor

Hi, I'm from Software Mansion, an expert agency, and I'd like to work on this issue.

@marcaaron marcaaron changed the title [HOLD][$250] Migrate ReportScreen.js to function component [$250] Migrate ReportScreen.js to function component Aug 1, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Aug 1, 2023
@marcaaron marcaaron self-assigned this Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0184e14afba16fa311

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@ghost
Copy link

ghost commented Aug 1, 2023

Dibs

@ishpaul777
Copy link
Contributor

Would love to take this

@hanzalahsamana
Copy link

The proposal aims to migrate the existing ReportScreen.js file from a class component to a function component with React hooks. This migration will enhance code readability, maintainability, and adhere to modern React best practices. The steps include refactoring the class component to a function component, removing unnecessary state and lifecycle methods, introducing React hooks for state management and side effects, handling props, and updating event handlers. The benefits of this migration include improved code readability, better performance, and easier future upgrades. The goal is to provide a more robust and efficient ReportScreen component for the application.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

📣 @hanzalahsamana! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Habben101
Copy link

Would love to work on this

@hanzalahsamana
Copy link

Your Expensify account email: hanzalahsamana789@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~019b0a755f7bda1754

@Muhammad-Saqib-980
Copy link

I would love to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

📣 @Muhammad-Saqib-980! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Muhammad-Saqib-980
Copy link

Contributor details
Your Expensify account email: saqibtariq980@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010d8b5416650c0aa1

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Re-Dei
Copy link

Re-Dei commented Aug 2, 2023

I would like to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @Re-Dei! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Re-Dei
Copy link

Re-Dei commented Aug 2, 2023

Contributor details
Your Expensify account email: hridaya.pradhan123@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0169022423ba77b59f

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@alexxxwork
Copy link
Contributor

I would love to work on this issue

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 4, 2023
@SosenWiosen
Copy link
Contributor

@aimane-chnaif waiting for a review :)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

This issue has not been updated in over 15 days. @marcaaron, @SosenWiosen, @flaviadefaria, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@aimane-chnaif
Copy link
Contributor

PR was deployed to production on Aug 30

@blazejkustra
Copy link
Contributor

@marcaaron Can we close this issue as PR was merged a while ago? 😄

@aimane-chnaif
Copy link
Contributor

yes, we can close this issue

@flaviadefaria
Copy link
Contributor

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests