refactor(expensify card): apply code guidelines

Expensify · Sep 11, 2023 · 760fcb3 · 760fcb3
1 parent 90f323a
commit 760fcb3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/components/CardPreview.js b/src/components/CardPreview.js
@@ -2,12 +2,10 @@ import React from 'react';
 import {View} from 'react-native';
 import {withOnyx} from 'react-native-onyx';
 import PropTypes from 'prop-types';
-
 import styles from '../styles/styles';
 import Text from './Text';
 import usePrivatePersonalDetails from '../hooks/usePrivatePersonalDetails';
 import ONYXKEYS from '../ONYXKEYS';
-
 import ExpensifyCardImage from '../../assets/images/expensify-card.svg';
 
 const propTypes = {
@@ -32,12 +30,9 @@ const defaultProps = {
     },
 };
 
-function CardPreview(props) {
+function CardPreview({privatePersonalDetails: {legalFirstName, legalLastName}, session: {email}}) {
     usePrivatePersonalDetails();
-    const legalFirstName = props.privatePersonalDetails.legalFirstName || '';
-    const legalLastName = props.privatePersonalDetails.legalLastName || '';
-
-    const cardHolder = legalFirstName && legalLastName ? `${legalFirstName} ${legalLastName}` : props.session.email;
+    const cardHolder = legalFirstName && legalLastName ? `${legalFirstName} ${legalLastName}` : email;
 
     return (
         <View style={styles.walletCard}>
@@ -59,7 +54,7 @@ function CardPreview(props) {
 
 CardPreview.propTypes = propTypes;
 CardPreview.defaultProps = defaultProps;
-CardPreview.displayName = CardPreview;
+CardPreview.displayName = 'CardPreview';
 
 export default withOnyx({
     privatePersonalDetails: {

diff --git a/src/pages/settings/Wallet/ExpensifyCardPage.js b/src/pages/settings/Wallet/ExpensifyCardPage.js
@@ -8,7 +8,6 @@ import Navigation from '../../../libs/Navigation/Navigation';
 import styles from '../../../styles/styles';
 import * as CurrencyUtils from '../../../libs/CurrencyUtils';
 import MenuItemWithTopDescription from '../../../components/MenuItemWithTopDescription';
-
 import CardPreview from '../../../components/CardPreview';
 import useLocalize from '../../../hooks/useLocalize';
 
@@ -55,6 +54,6 @@ function ExpensifyCardPage(props) {
 
 ExpensifyCardPage.propTypes = propTypes;
 ExpensifyCardPage.defaultProps = defaultProps;
-ExpensifyCardPage.displayName = ExpensifyCardPage;
+ExpensifyCardPage.displayName = 'ExpensifyCardPage';
 
 export default ExpensifyCardPage;