This repository was archived by the owner on Jul 2, 2024. It is now read-only.
Fix HTML content editor #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor exchangecalendar <4.0 did a test on existence of an element with id "todo-entrydate" to decide whether it should display or hide the HTML content editor. (this code was in the onLoad() function of calendar-event-dialog.js) Because of the name of the ID, I misunderstood the test and thought the HTML editor has to be displayed only for tasks. This commit fixes the dialog display. The next one will fix the content saving.
Fix #29: as we know save content to HTML body, we are correctly synced with exchange server.
As we removed this CSS from event-dialog, the font color and background color buttons were not any more correctly displayed in the HTML editor.
This ensures us that button are in a ready state when we apply commands
…ue with uninitilized interface Note that desctructor and constructor were not handling handlers on the same phase.
…ditor As advised by the "Rapid Application Development with Mozilla" book by Nigel McFarlane. Indeed, a tag sole any binding when we use attribute like "display:none" because a XBL binding requires a frame (styleable area). Fixes #28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patch makes a main cleanup of the HTML content editor:
It includes commits from #30 , so it will fixes #29 too.
That was needed as the fix for the initialization modified same files than the one for event contents.