This repository was archived by the owner on Jul 2, 2024. It is now read-only.
Fix builds on macOS #142
Merged
Fix builds on macOS #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 26, 2018 12:16
This avoids modifying source-controlled files from build. This also avoids use of nonstandard -i option (whose backup-less form differs between the GNU version and the BSD/macOS version).
The source is one of the two update_*.txt files. Create unconditionally, because the $(update) value may change from time to time and there is no way to determine if it has changed.
This is to avoid repetition and, in turn, copy-and-paste glitches later.
Without this, if make were re-run after removing a source file from the repository, the removed file would not be retired out of the XPI file, causing confusion.
This is because install.rdf is no longer source-controlled.
Taking the current directory when no path is given is a GNU extension and breaks macOS builds.
|
Thanks, these modifications were indeed needed. That was a good idea to use a template for the RDF, that's more robust than the older regular expressions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a few platform differences such as
sed -ioption and omitting the current directory if it is the only path argument tofind.Also, make builds repeatable and not touch source-controlled files, and .gitignore build artifacts.