Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

"Microsoft Exchange EWS: Password request." title shouldn't have a period #229

Closed
jsoref opened this issue Dec 7, 2018 · 3 comments
Closed

"Microsoft Exchange EWS: Password request." title shouldn't have a period #229

jsoref opened this issue Dec 7, 2018 · 3 comments

Comments

@jsoref
Copy link

jsoref commented Dec 7, 2018

image

Two basic thoughts:

  1. Titles are not sentence like things and shouldn't include periods.
  2. The title of a dialog shouldn't generally replicate content within a dialog (or conversely a dialog's content should repeat its title)

I suspect this is from https://github.com/ExchangeCalendar/exchangecalendar/blob/master/common/interface/exchangeAuthPrompt2/mivExchangeAuthPrompt2.js#L733

I'm running Thunderbird.app 60.3.3 (64-bit) w/ Exchange Calendar 5.0.0-alpha2
advancingu added a commit that referenced this issue Feb 8, 2019
@advancingu
#229 Improve password request dialog title
b219d8e 
* Refactor dialog title to be translatable string.
* Improve dialog title.
* Improve code formatting.
@advancingu
Copy link
Member

@jsoref This was quite tough to figure out a proper solution. It turned out the entire string was hardcoded in English. Please check now.

@jsoref
Copy link
Author

jsoref commented Feb 11, 2019

@advancingu : aww, but I gave you the pointer to the string!

That said, the PR looks good. (I'm unlikely to build my own package, although in a past life I would have, I'm bug reporting on behalf of someone else.)

advancingu added a commit that referenced this issue Feb 14, 2019
@advancingu
#229 Improve password request dialog title
b485bd4 
* Add translations.
advancingu added a commit that referenced this issue Feb 14, 2019
@advancingu
Merge pull request #246 from ExchangeCalendar/229-password-window-title
9b09611 
#229 Improve password request dialog title
@advancingu
Copy link
Member

Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@advancingu @jsoref