Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip tests during publishing of release #3744

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jan 31, 2025

Tests were failing for unknown reasons: https://github.com/Eventual-Inc/Daft/actions/runs/13064922153/job/36455524516

We skip tests now when publishing, and should just use main as the source of truth

@github-actions github-actions bot added the ci label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #3744 will degrade performances by 34.37%

Comparing jay/fix-package-build (37d4c66) with main (3462732)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 225.7 ms 176.1 ms +28.15%
test_show[100 Small Files] 15.8 ms 24 ms -34.37%

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (3462732) to head (37d4c66).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3744   +/-   ##
=======================================
  Coverage   77.65%   77.65%           
=======================================
  Files         731      731           
  Lines       92379    92379           
=======================================
  Hits        71734    71734           
  Misses      20645    20645           

@jaychia jaychia changed the title ci: Fix for package release ci: skip tests during publishing of release Jan 31, 2025
@jaychia jaychia enabled auto-merge (squash) January 31, 2025 02:58
@jaychia jaychia merged commit 2d0d8b2 into main Jan 31, 2025
41 of 42 checks passed
@jaychia jaychia deleted the jay/fix-package-build branch January 31, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant