Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new dashboard UI to Daft #3738

Merged
merged 5 commits into from
Jan 30, 2025
Merged

feat: Add a new dashboard UI to Daft #3738

merged 5 commits into from
Jan 30, 2025

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Jan 29, 2025

Overview

This PR introduces a new sub-directory, called /dashboard, that contains a Next.js dashboard application. The UI is styled using shadcn.

Notes

The current dashboard is quite simple; it only contains the basic frame, two items in the sidebar, and a blank screen.

The dashboard currently looks like:

image

@github-actions github-actions bot added the feat label Jan 29, 2025
@raunakab raunakab requested a review from jaychia January 29, 2025 21:58
@raunakab raunakab marked this pull request as ready for review January 29, 2025 21:58
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #3738 will degrade performances by 18.22%

Comparing dashboard (0efb166) with main (78beff4)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 153.1 ms 187.2 ms -18.22%

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (960f144) to head (0efb166).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
- Coverage   77.58%   77.51%   -0.07%     
==========================================
  Files         729      731       +2     
  Lines       92003    92511     +508     
==========================================
+ Hits        71378    71714     +336     
- Misses      20625    20797     +172     

see 45 files with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, can we also check the binary sizes/amount of stuff we have to download for the dashboard? Would definitely like to keep it lightweight if possible.

Also if possible, lets remove any runtime dependencies on bun, prometheus and grafana

@raunakab raunakab merged commit b8a3669 into main Jan 30, 2025
43 of 44 checks passed
@raunakab raunakab deleted the dashboard branch January 30, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants