Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(join): joining on different types #3716

Merged
merged 9 commits into from
Jan 29, 2025

add test

3dc2398
Select commit
Loading
Failed to load commit list.
Merged

fix(join): joining on different types #3716

add test
3dc2398
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 22, 2025 in 1s

92.08% of diff hit (target 77.91%)

View this Pull Request on Codecov

92.08% of diff hit (target 77.91%)

Annotations

Check warning on line 1462 in src/daft-dsl/src/expr/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-dsl/src/expr/mod.rs#L1460-L1462 

Added lines #L1460 - L1462 were not covered by tests

Check warning on line 1469 in src/daft-dsl/src/expr/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-dsl/src/expr/mod.rs#L1469 

Added line #L1469 was not covered by tests

Check warning on line 44 in src/daft-dsl/src/join.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-dsl/src/join.rs#L44 

Added line #L44 was not covered by tests

Check warning on line 376 in src/daft-local-execution/src/pipeline.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-local-execution/src/pipeline.rs#L374-L376 

Added lines #L374 - L376 were not covered by tests

Check warning on line 169 in src/daft-local-execution/src/sinks/outer_hash_join_probe.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-local-execution/src/sinks/outer_hash_join_probe.rs#L169 

Added line #L169 was not covered by tests

Check warning on line 60 in src/daft-logical-plan/src/ops/join.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/ops/join.rs#L55-L60 

Added lines #L55 - L60 were not covered by tests

Check warning on line 70 in src/daft-logical-plan/src/ops/join.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/ops/join.rs#L68-L70 

Added lines #L68 - L70 were not covered by tests

Check warning on line 80 in src/daft-logical-plan/src/ops/join.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/ops/join.rs#L76-L80 

Added lines #L76 - L80 were not covered by tests

Check warning on line 166 in src/daft-logical-plan/src/treenode.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/treenode.rs#L166 

Added line #L166 was not covered by tests

Check warning on line 174 in src/daft-logical-plan/src/treenode.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-logical-plan/src/treenode.rs#L174 

Added line #L174 was not covered by tests
View more details on Codecov