Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose parquet chunk size to swordfish reads #3714

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Jan 21, 2025

Parquet reads in swordfish currently do not respect the _chunk_size parameter that users pass in.

@github-actions github-actions bot added the feat label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (4b8397b) to head (b0ad779).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3714      +/-   ##
==========================================
+ Coverage   76.91%   77.91%   +0.99%     
==========================================
  Files         727      727              
  Lines       93172    91137    -2035     
==========================================
- Hits        71665    71010     -655     
+ Misses      21507    20127    -1380     
Files with missing lines Coverage Δ
src/daft-local-execution/src/sources/scan_task.rs 76.60% <100.00%> (+0.15%) ⬆️
src/daft-parquet/src/read.rs 75.36% <100.00%> (+0.17%) ⬆️
src/daft-parquet/src/stream_reader.rs 89.31% <100.00%> (+0.01%) ⬆️

... and 27 files with indirect coverage changes

@colin-ho colin-ho requested a review from kevinzwang January 29, 2025 19:41
@colin-ho colin-ho merged commit 4048816 into main Jan 29, 2025
44 checks passed
@colin-ho colin-ho deleted the colin/expose-parquet-chunk-size branch January 29, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants