Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: higher quality daft diagram for readme #3697

Merged
merged 1 commit into from
Jan 16, 2025
Merged

docs: higher quality daft diagram for readme #3697

merged 1 commit into from
Jan 16, 2025

Conversation

ccmao1130
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the docs label Jan 16, 2025
Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #3697 will degrade performances by 28.66%

Comparing daft-diagram (7e130e3) with main (e7abec3)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main daft-diagram Change
test_iter_rows_first_row[100 Small Files] 164.2 ms 230.2 ms -28.66%

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (e7abec3) to head (7e130e3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   77.89%   76.97%   -0.92%     
==========================================
  Files         721      719       -2     
  Lines       90422    91419     +997     
==========================================
- Hits        70434    70371      -63     
- Misses      19988    21048    +1060     

see 26 files with indirect coverage changes

@ccmao1130 ccmao1130 merged commit d82a9d7 into main Jan 16, 2025
42 of 43 checks passed
@ccmao1130 ccmao1130 deleted the daft-diagram branch January 16, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant