Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove daft tracing #3692

Merged
merged 2 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .github/ci-scripts/format_env_vars.py

This file was deleted.

5 changes: 0 additions & 5 deletions .github/ci-scripts/job_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,13 @@ def submit_job(
entrypoint_script: str,
entrypoint_args: str,
env_vars: str,
enable_ray_tracing: bool,
):
if "GHA_OUTPUT_DIR" not in os.environ:
raise RuntimeError("Output directory environment variable not found; don't know where to store outputs")
output_dir = Path(os.environ["GHA_OUTPUT_DIR"])
output_dir.mkdir(exist_ok=True, parents=True)

env_vars_dict = parse_env_var_str(env_vars)
if enable_ray_tracing:
env_vars_dict["DAFT_ENABLE_RAY_TRACING"] = "1"

client = JobSubmissionClient(address="http://localhost:8265")

Expand Down Expand Up @@ -116,7 +113,6 @@ def submit_job(
parser.add_argument("--entrypoint-script", type=str, required=True)
parser.add_argument("--entrypoint-args", type=str, required=True)
parser.add_argument("--env-vars", type=str, required=True)
parser.add_argument("--enable-ray-tracing", action="store_true")

args = parser.parse_args()

Expand All @@ -132,5 +128,4 @@ def submit_job(
entrypoint_script=args.entrypoint_script,
entrypoint_args=args.entrypoint_args,
env_vars=args.env_vars,
enable_ray_tracing=args.enable_ray_tracing,
)
9 changes: 4 additions & 5 deletions .github/workflows/run-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,12 @@ jobs:
--entrypoint-script='${{ inputs.entrypoint_script }}' \
--entrypoint-args='${{ inputs.entrypoint_args }}' \
--env-vars='${{ inputs.env_vars }}' \
--enable-ray-tracing
- name: Download log files from ray cluster
if: always()
run: |
source .venv/bin/activate
ray rsync-down .github/assets/ray.yaml /tmp/ray/session_*/logs ray-daft-logs
find ray-daft-logs -depth -name '*:*' -exec bash -c '
ray rsync-down .github/assets/ray.yaml /tmp/ray/session_*/logs ray-logs
find ray-logs -depth -name '*:*' -exec bash -c '
for filepath; do
dir=$(dirname "$filepath")
base=$(basename "$filepath")
Expand Down Expand Up @@ -173,5 +172,5 @@ jobs:
if: always()
uses: actions/upload-artifact@v4
with:
name: ray-daft-logs
path: ray-daft-logs
name: ray-logs
path: ray-logs
Loading